Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: browser sat #51

Merged
merged 22 commits into from
Dec 28, 2023
Merged

feat: browser sat #51

merged 22 commits into from
Dec 28, 2023

Conversation

mikejgray
Copy link
Contributor

Description

Introduces a web browser voice satellite option with OpenWakeWord and Silero VAD running in JavaScript, all served via FastAPI. Allows for both text and voice commands to a Neon Diana deployment.

This new option may one day replace the Gradio webpage.

NeonDaniel
NeonDaniel reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial feedback from reading through changes; I'll pull and test later today.

Dockerfile.websat Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
neon_iris/models/__init__.py Show resolved Hide resolved
neon_iris/models/web_sat.py Show resolved Hide resolved
neon_iris/web_client.py Outdated Show resolved Hide resolved
neon_iris/web_sat_client.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
@NeonDaniel
Copy link
Member

I'm not sure how simple/difficult it would be but if the "Listening" text could hook into the recognizer state and report "Waiting for Wake Word" and "Recording Speech" (or something like that), it would be easier to use this page without audio and make it more obvious when recording input has stopped

@NeonDaniel NeonDaniel mentioned this pull request Dec 20, 2023
Merged
@mikejgray
Copy link
Contributor Author

I'm not sure how simple/difficult it would be but if the "Listening" text could hook into the recognizer state and report "Waiting for Wake Word" and "Recording Speech" (or something like that), it would be easier to use this page without audio and make it more obvious when recording input has stopped

Next round. I was noticing that as well, so we at least want a variation of the spinning wheel "thinking" icon.

@mikejgray mikejgray requested a review from NeonDaniel December 21, 2023 05:55
NeonDaniel
NeonDaniel reviewed Dec 21, 2023
View reviewed changes
.github/workflows/publish_test_websat_build.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@NeonDaniel NeonDaniel mentioned this pull request Dec 21, 2023
Merged
NeonDaniel
NeonDaniel reviewed Dec 21, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@mikejgray mikejgray requested a review from NeonDaniel December 22, 2023 04:56
@mikejgray
Copy link
Contributor Author

I'm not sure how simple/difficult it would be but if the "Listening" text could hook into the recognizer state and report "Waiting for Wake Word" and "Recording Speech" (or something like that), it would be easier to use this page without audio and make it more obvious when recording input has stopped

Next round. I was noticing that as well, so we at least want a variation of the spinning wheel "thinking" icon.

Never mind @NeonDaniel , I went ahead and added it :)

NeonDaniel
NeonDaniel reviewed Dec 27, 2023
View reviewed changes
entrypoint.sh Outdated Show resolved Hide resolved
entrypoint.sh Outdated Show resolved Hide resolved
NeonDaniel
NeonDaniel reviewed Dec 28, 2023
View reviewed changes
entrypoint.sh Outdated Show resolved Hide resolved
@mikejgray mikejgray requested a review from NeonDaniel December 28, 2023 02:28
NeonDaniel
NeonDaniel requested changes Dec 28, 2023
View reviewed changes
Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs GHA updates. mikejgray#1 should do it

@mikejgray
Merge pull request #1 from NeonDaniel/FEAT_BrowserSat
db71351 
Update automation to support shared GHA updates
@mikejgray mikejgray requested a review from NeonDaniel December 28, 2023 18:06
@NeonDaniel NeonDaniel merged commit 824a912 into NeonGeckoCom:dev Dec 28, 2023
6 checks passed
@mikejgray mikejgray deleted the FEAT_BrowserSat branch December 28, 2023 19:25
@NeonDaniel NeonDaniel mentioned this pull request May 13, 2024
Closed
@mikejgray mikejgray mentioned this pull request May 14, 2024
Merged
NeonDaniel pushed a commit that referenced this pull request May 14, 2024
@mikejgray
fix: appropriate dependencies (#61)
8060a93 
# Description
Fixes the gradio audio input bug introduced in #51 

# Issues
Closes #59 
Replaces #60 

# Other Notes
Breaks caching quite a bit, so if that's an issue we can create a helper
image that we use to pull in dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonDaniel NeonDaniel NeonDaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikejgray @NeonDaniel