For 1.1.3 release #263
Merged
For 1.1.3 release #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't seem to work properly with InstancedMeshes. Only the first character of the console text is repeated again and again, as if it's being re-written each time an instance of the mesh is created. So, remove the text entirely. Will document usage elsewhere.
to return the required meshdata
Required for new vispy plotting
chore(deps): remove unused pandas
The logic here is that if a user provides us a file to plot, we don't need to load all the includes in the file and so on. We can load only the information we need to plot the morphology plots and disregard the other information. However, if a loaded model is given, we just use that---it's already in memory, and there's no point of copying it to remove things, since that'll just use even more memory.
So that we take the total number of segments to be plotted into account, not segments on individual cells.
Otherwise it interrupts the progressbar
Here, the two radii will be the same, but length can be 0, and we model this as a sphere.
Warning: will lead to lots of output
.. that do not have a morphology
We implement a heuristic based on a `precision` tuple. This takes two parameters: - the number of decimals that should be used to group segments into meshes - the total number of meshes to limit the visualization to. In general, more meshes means more detail, but less performance. Here, the user can provide what precision they want to use. The method includes a heuristic where it will reduce precision until the number of meshes being used is less than the provided threshold value.
Instanced meshes were introduced in 0.13.0, so we need at least that: https://github.com/vispy/vispy/releases/tag/v0.13.0
Improve performance of vispy plotter using meshes and their instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.