Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql: enable tests on darwin #318383

Closed
wants to merge 1 commit into from
Closed

Conversation

kirillrdy
Copy link
Member

@kirillrdy kirillrdy commented Jun 8, 2024

blocked by NixOS/nix#10878

related issues #198495

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kirillrdy kirillrdy closed this Jun 8, 2024
@kirillrdy kirillrdy reopened this Jun 10, 2024
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 10, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 10, 2024
they were disabled in 0c3b7ea but seems
to be working now
@wolfgangwalther
Copy link
Contributor

I tried this a few days ago, and one big problem is System Integrity Protection. Having this enabled will reset DYDL_LIBRARY_PATH, which is required while running the tests. Also see the upstream discussion.

One thing to work around that would be to move the tests to the install check phase, i.e.

doCheck = false;
doInstallCheck = true;
installCheckTarget = "check";

I have not succeeded with that though. So before tests can be enabled for darwin, this needs to be sorted out, too.

@kirillrdy
Copy link
Member Author

I tried this a few days ago, and one big problem is System Integrity Protection. Having this enabled will reset DYDL_LIBRARY_PATH, which is required while running the tests. Also see the upstream discussion.

One thing to work around that would be to move the tests to the install check phase, i.e.

doCheck = false;
doInstallCheck = true;
installCheckTarget = "check";

I have not succeeded with that though. So before tests can be enabled for darwin, this needs to be sorted out, too.

@wolfgangwalther hey, thank you for response.

With a change to sandbox ( PR in description ) postgresql with doCheck = true; builds fine ( although I didn't check if it ran tests )

 nix-info -m
warning: unknown setting 'upgrade-nix-store-path-url'
 - system: `"x86_64-darwin"`
 - host os: `Darwin 22.6.0, macOS 10.16`
 - multi-user?: `yes`
 - sandbox: `yes`
warning: unknown setting 'upgrade-nix-store-path-url'
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `/nix/store/cy8fiajvwb80m83zxz300hwfjl0g8rna-source`

is System Integrity Protection not enabled in my set up ? How do I check ? ( i am not a mac guy )

@wolfgangwalther
Copy link
Contributor

is System Integrity Protection not enabled in my set up ? How do I check ? ( i am not a mac guy )

You can run csrutil status. If it says something else than just System Integrity Protection status: enabled... then it's not.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@wolfgangwalther
Copy link
Contributor

Superseded by #358248

@kirillrdy kirillrdy deleted the postgresql branch November 22, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants