postgresql: enable tests on darwin #358248
Conversation
|
Seems like the installCheck phase gets stuck for me on darwin for v13 and v14. It works for v15 and up, though. Can anyone confirm that? Or is that a me-problem only? |
This happened very repeatable. I assume there is some error, but I can't see it. I also found #357879, which could describe the same thing happen elsewhere. Even if we can only enable tests for 15+ on darwin, that would already be a big +. |
There was a problem hiding this comment.
fwiw postgresql 13 to 17 build fine for me on this branch with system integrity protection enabled on macos 15.1.1.
I have no way to test macos <15 though.
If this only happens with pg <15, I'd say let's skip the tests for darwin on <15, the issue will resolve itself in two years then ;-)
Interesting. I'm testing on the community builder with macos 14.7.1. I'll test it again to rule out the builder being overloaded or so as the reason.... yeah - still times out at some point. I'll play a bit with different options for running the tests in parallel or not. |
ofborg
bot
added
11.by: package-maintainer
The tests were disabled in NixOS#62752. The problem is System Integrity Protection on macOS, which resets DYDL_LIBRARY_PATH and thus breaks the temporary installation of PostgreSQL. By running the checks *after* the installPhase, the libraries will already be available in the default locations.
wolfgangwalther
force-pushed
the
postgresql-darwin-check-staging
branch
from
e57c22e to
9869d7f
Compare
No success. I disabled the tests for v13 and v14 on darwin. I did not build any JIT variants, yet, did you already, @Ma27? |
Did so, those worked as well. |
|
Did the same in the meantime, also looking good. |
The tests were disabled in #62752. The problem is System Integrity Protection on macOS, which resets DYDL_LIBRARY_PATH and thus breaks the temporary installation of PostgreSQL. By running the checks after the installPhase, the libraries will already be available in the default locations.
Last time I tried this, it didn't work. It does this time, so let's make sure to enable the tests on darwin and never let them break again :)
Supersedes #318383
Make sure to test this with System Integrity Protection enabled. If it's disabled, the tests will work anyway. You can check with
csrutil status.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.