-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bleep: init at 0.0.7 #321599
bleep: init at 0.0.7 #321599
Conversation
Is there anything missing for this to be merged? |
As you merged So once you got the commits right, either by rebase/squash/fixup on your current PR or by creating a fresh one, feel free to ping me for a proper review. Some additional notes:
|
f726d24
to
35596d2
Compare
@NobbZ I think everything should be in order now. The platform names I assume should be the ones defined in lib.platform., i.e. libs.platform.aarch64 which gives aarch64-darwin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use distinct commits for adding yourself as a maintainer and adding the package.
maintainers: add KristianAN
bleep: init at 0.0.7
@NobbZ is this good to merge? |
Scala build tool bleep. https://github.com/oyvindberg/bleep/releases/tag/v0.0.7 A fast modern build tool for Scala with a declarative configuration.
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1952 |
Description of changes
Added new package: Bleep - A fast modern build tool for Scala with a declarative configuration: https://bleep.build
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to issues you find important.