Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bleep: init at 0.0.7 #321599

Merged
merged 2 commits into from
Sep 14, 2024
Merged

bleep: init at 0.0.7 #321599

merged 2 commits into from
Sep 14, 2024

Conversation

KristianAN
Copy link
Contributor

@KristianAN KristianAN commented Jun 21, 2024

Description of changes

Added new package: Bleep - A fast modern build tool for Scala with a declarative configuration: https://bleep.build

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to issues you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 21, 2024
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 21, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 21, 2024
@KristianAN
Copy link
Contributor Author

Is there anything missing for this to be merged?

@KristianAN KristianAN changed the title bleep: init at 0.0.4 bleep: init at 0.0.5 Jul 31, 2024
@NobbZ
Copy link
Contributor

NobbZ commented Aug 22, 2024

As you merged master back into your PR, getting the commits right now might become a mess easily, therefore feel free to close and recreate the PR, making sure that you follow the commit conventions.

So once you got the commits right, either by rebase/squash/fixup on your current PR or by creating a fresh one, feel free to ping me for a proper review.


Some additional notes:

  1. Please move platform and hash into a let-binding. Especially platform doesn't seem to be used for anything but constructing the URL.
  2. Instead of using is* predicates use "poor mans switch" to construct platform and hash, eg.
    let platform = {
      x86_64-linux = "x86_64-pc-linux";
      aarch64-darwin = "arm64-apple-darwin";
      # etc
    }."${stdenv.system}"; in

@KristianAN KristianAN force-pushed the master branch 2 times, most recently from f726d24 to 35596d2 Compare August 28, 2024 12:08
@KristianAN
Copy link
Contributor Author

@NobbZ I think everything should be in order now. The platform names I assume should be the ones defined in lib.platform., i.e. libs.platform.aarch64 which gives aarch64-darwin.

@KristianAN KristianAN changed the title bleep: init at 0.0.5 bleep: init at 0.0.7 Aug 28, 2024
Copy link
Contributor

@NobbZ NobbZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use distinct commits for adding yourself as a maintainer and adding the package.

  1. maintainers: add KristianAN
  2. bleep: init at 0.0.7

@KristianAN KristianAN requested a review from NobbZ August 28, 2024 19:45
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 28, 2024
pkgs/by-name/bl/bleep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/bleep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/bleep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/bleep/package.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Aug 29, 2024
@KristianAN
Copy link
Contributor Author

@NobbZ is this good to merge?

pkgs/by-name/bl/bleep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/bleep/package.nix Outdated Show resolved Hide resolved
NobbZ
NobbZ previously requested changes Sep 6, 2024
pkgs/by-name/bl/bleep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/bleep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/bleep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/bleep/package.nix Show resolved Hide resolved
pkgs/by-name/bl/bleep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/bleep/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bl/bleep/package.nix Show resolved Hide resolved
Scala build tool bleep.
https://github.com/oyvindberg/bleep/releases/tag/v0.0.7
A fast modern build tool for Scala with a declarative configuration.
@d-brasher
Copy link
Contributor

Result of nixpkgs-review pr 321599 run on x86_64-linux 1

1 package built:
  • bleep

Copy link
Contributor

@d-brasher d-brasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

pkgs/by-name/bl/bleep/package.nix Show resolved Hide resolved
@Pandapip1 Pandapip1 added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Sep 13, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1952

@Aleksanaa Aleksanaa merged commit ae40014 into NixOS:master Sep 14, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants