-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.pytest-cov-stub: init at 1.0.0 #328550
python3Packages.pytest-cov-stub: init at 1.0.0 #328550
Conversation
Result of 20 packages built:
|
Interesting. Seems like a reasonable enough approach. Is |
coverage testing is a developer sanity test, not neccesarily a correctness test. It should not block distribution and common practice in nixpkgs is to patch it out, as shown in some of the examples in this PR. EDIT: also it puts the interpreter in a mode where it records all lines executed, which greatly slows down the test suite. |
2d45c5c
to
4619c4c
Compare
I pushed a change that re-implements the stubs rather than wrap the ones from |
Result of 20 packages built:
|
@ofborg build python311Packages.pytest-cov-stub python312Packages.pytest-cov-stub |
Successfully created backport PR for |
Description of changes
#327220 (comment) finally inspired me to implement this idea I've been brewing for quite a while: a
pytest-cov
stub that does nothing but accept the command line options and provide empty no-op fixtures.follow-up candidates for stubbing:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.