-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
orca-slicer: 2.1.1 -> 2.2.0 #352156
orca-slicer: 2.1.1 -> 2.2.0 #352156
Conversation
There is also this PR: which fixes some bugs and adds another maintainer. #348091 |
rebased and retested, |
Built @jonboh for future reference, please do not create pull requests to git repositories from your master branch. Doing so makes simple commands like |
Runs fine for me, tested using this overlay (orca-slicer.overrideAttrs (
final: prev: {
version = "2.2.0";
src = fetchFromGitHub {
owner = "SoftFever";
repo = "OrcaSlicer";
rev = "v${final.version}";
hash = "sha256-h+cHWhrp894KEbb3ic2N4fNTn13WlOSYoMsaof0RvRI=";
};
patches = builtins.filter (
p:
(builtins.baseNameOf p) != "0002-fix-build-for-gcc-13.diff"
&& (builtins.baseNameOf p) != "meshboolean-const.patch"
) prev.patches;
}
)) |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)I've removed
previousAttrs.patches
from patches as the latest stable release of BambuStudio still needs themeshboolean-const.patch
, but OrcaSlicer has already performed this change in their own code. Once the stable release of BambuStudio fixes that issue as well it can be added back again and remove the explicit mention of the 0001 patch. Also, the 0002 patch is no longer necessary.Add a 👍 reaction to pull requests you find important.