pulumi: 3.122.0 -> 3.137.0 #352221
Open
pulumi: 3.122.0 -> 3.137.0 #352221
+55
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
saiintbrisson
commented
Oct 29, 2024
There was a problem hiding this comment.
I'm open to ideas on how else to do this
saiintbrisson
commented
Oct 29, 2024
pkgs/tools/admin/pulumi/default.nix
Outdated
Comment on lines
99
to
106
| "TestProgressEvents" | ||
| # This test depends on having a PULUMI_ACCESS_TOKEN but is not skipped when one is not provided. | ||
| # Other tests are skipped when the env var is missing. I guess they forgot about this one. | ||
| "TestPulumiNewSetsTemplateTag/python" | ||
| # Both tests require having a "pulumi-language-yaml" plugin installed since pulumi/pulumi#17285, | ||
| # which I'm not sure how to add. | ||
| "TestProjectNameDefaults" | ||
| "TestProjectNameOverrides" |
There was a problem hiding this comment.
Pulumi tests are very flaky.
saiintbrisson
commented
Oct 30, 2024
Comment on lines
+16
to
+20
| cmdGenPostConfigure = '' | ||
| pushd .. | ||
| cp versions/v2-lock.json provider/pkg/versionLookup/ | ||
| popd | ||
| ''; |
There was a problem hiding this comment.
Both builds require this file as it is embedded in a common file. Their makefile does this manually as well.
|
Does this resolve #351955 ? |
I wasn't aware of this issue but Im guessing it does. Had no problems building pulumi and packages on darwin, at least. I suppose it wont fail in linux either. |
|
👍 I imagine it does (if it wasn't fixed already somewhere on master/unstable), ofborg seems happy. |
|
Tried to apply this PR as a patch in a nix flake on an Ubuntu WSL2 instance and got this: error: builder for '/nix/store/md0cg0n0fq2qv6x56yz631d1xhzlw9db-pulumi-3.137.0.drv' failed with exit code 1;
last 25 log lines:
> panic: fatal: A precondition has failed for path: must not be empty
>
> goroutine 130 [running]:
> testing.tRunner.func1.2({0x25b52c0, 0xc0019ba240})
> /nix/store/klw1ipjsqx1np7pkk833x7sad7f3ivv9-go-1.23.2/share/go/src/testing/testing.go:1632 +0x230
> testing.tRunner.func1()
> /nix/store/klw1ipjsqx1np7pkk833x7sad7f3ivv9-go-1.23.2/share/go/src/testing/testing.go:1635 +0x35e
> panic({0x25b52c0?, 0xc0019ba240?})
> /nix/store/klw1ipjsqx1np7pkk833x7sad7f3ivv9-go-1.23.2/share/go/src/runtime/panic.go:785 +0x132
> github.com/pulumi/pulumi/sdk/v3/go/common/util/contract.failfast(...)
> /build/pulumi/pkg/vendor/github.com/pulumi/pulumi/sdk/v3/go/common/util/contract/failfast.go:23
> github.com/pulumi/pulumi/sdk/v3/go/common/util/contract.Requiref(0x68?, {0x2add276?, 0x5?}, {0x2b357a0, 0x11}, {0x0, 0x0, 0x0})
> /build/pulumi/pkg/vendor/github.com/pulumi/pulumi/sdk/v3/go/common/util/contract/require.go:35 +0x199
> github.com/pulumi/pulumi/sdk/v3/go/common/workspace.LoadProject({0x0, 0x0})
> /build/pulumi/pkg/vendor/github.com/pulumi/pulumi/sdk/v3/go/common/workspace/loaders.go:90 +0x55
> github.com/pulumi/pulumi/pkg/v3/cmd/pulumi.loadProject(0xc002958000, {0xc002996000?, 0x3269be0?})
> /build/pulumi/pkg/cmd/pulumi/new_acceptance_test.go:255 +0x59
> github.com/pulumi/pulumi/pkg/v3/cmd/pulumi.TestPulumiNewSetsTemplateTag.func1(0xc002958000)
> /build/pulumi/pkg/cmd/pulumi/new_test.go:1123 +0x275
> testing.tRunner(0xc002958000, 0xc002884000)
> /nix/store/klw1ipjsqx1np7pkk833x7sad7f3ivv9-go-1.23.2/share/go/src/testing/testing.go:1690 +0xf4
> created by testing.(*T).Run in goroutine 124
> /nix/store/klw1ipjsqx1np7pkk833x7sad7f3ivv9-go-1.23.2/share/go/src/testing/testing.go:1743 +0x390
> FAIL github.com/pulumi/pulumi/pkg/v3/cmd/pulumi 0.190s
> FAIL
For full logs, run 'nix log /nix/store/md0cg0n0fq2qv6x56yz631d1xhzlw9db-pulumi-3.137.0.drv'.
error: 1 dependencies of derivation '/nix/store/hnzys3qgd2rbrd0ynspqbllvz26szjbr-nix-shell-env.drv' failed to build |
Could you please find the name of the failing test? You can do it by tapping into the full logs and searching for the line with |
|
Yes sure, here it is: --- FAIL: TestPulumiNewSetsTemplateTag (0.01s)
--- FAIL: TestPulumiNewSetsTemplateTag/typescript (0.01s)
new_test.go:1121:
Error Trace: /build/pulumi/pkg/cmd/pulumi/new_test.go:1121
Error: Received unexpected error:
cloning templates repo: Get "https://github.com/pulumi/templates.git/info/refs?service=>
Test: TestPulumiNewSetsTemplateTag/typescript
new_acceptance_test.go:254:
Error Trace: /build/pulumi/pkg/cmd/pulumi/new_acceptance_test.go:254
/build/pulumi/pkg/cmd/pulumi/new_test.go:1123
Error: Received unexpected error:
no Pulumi.yaml project file found (searching upwards from /build/TestPulumiNewSetsTempl>
Test: TestPulumiNewSetsTemplateTag/typescript
panic: fatal: A precondition has failed for path: must not be empty [recovered]
panic: fatal: A precondition has failed for path: must not be empty |
It seems like there's more to the right of |
|
Hitting github rate limits with this branch |
I've been facing this as well but I'm not sure what we should do except for disabling most tests. |
|
Would setting |
Oh, tysm. Seems like it does help, pushed it. |
|
Getting these failures on x86-64-linux: Logs |
wegank
added
the
2.status: merge conflict
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
This change upgrades pulumi through multiple versions and its relevante packages in
pulumi-packages.Packages in
pulumi-packageswere considerably outdated, some tweaks were necessary to make them work again:pulumi-aws-nativenow requires docs to be generated before generating the schema,pulumi-azure-nativerequires a newv2-lock.jsonfile to be copied to the correct path before building the gen command and resource,pulumi-language-{nodejs,python}fails to pass some tests that require special setup done through Pulumi's makefile, which I deem irrelevante here.pulumiitself also requires disabling and tweaking some tests.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.