-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pulumi: 3.122.0 -> 3.137.0 #352221
Open
saiintbrisson
wants to merge
2
commits into
NixOS:master
Choose a base branch
from
saiintbrisson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
pulumi: 3.122.0 -> 3.137.0 #352221
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,15 +4,20 @@ | |
mkPulumiPackage rec { | ||
owner = "pulumi"; | ||
repo = "pulumi-azure-native"; | ||
version = "2.13.0"; | ||
version = "2.69.0"; | ||
rev = "v${version}"; | ||
hash = "sha256-YyJxACeXyY7hZkTbLXT/ASNWa1uv9h3cvPoItR183fU="; | ||
vendorHash = "sha256-20wHbNE/fenxP9wgTSzAnx6b1UYlw4i1fi6SesTs0sc="; | ||
hash = "sha256-4kzLCBPHsSJHX7R4LOFYWoyQLdomihC6ppEnQQcdINE="; | ||
vendorHash = "sha256-JZNaez9jWQc2jMXTZywClb2/LAL1FuHLCJprV8MaFTk="; | ||
cmdGen = "pulumi-gen-azure-native"; | ||
cmdRes = "pulumi-resource-azure-native"; | ||
extraLdflags = [ | ||
"-X github.com/pulumi/${repo}/v2/provider/pkg/version.Version=${version}" | ||
]; | ||
cmdGenPostConfigure = '' | ||
pushd .. | ||
cp versions/v2-lock.json provider/pkg/versionLookup/ | ||
popd | ||
''; | ||
Comment on lines
+16
to
+20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Both builds require this file as it is embedded in a common file. Their makefile does this manually as well. |
||
postConfigure = '' | ||
pushd .. | ||
|
||
|
@@ -23,6 +28,7 @@ mkPulumiPackage rec { | |
|
||
cp bin/schema-full.json provider/cmd/${cmdRes} | ||
cp bin/metadata-compact.json provider/cmd/${cmdRes} | ||
cp versions/v2-lock.json provider/pkg/versionLookup/ | ||
|
||
popd | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,27 +15,18 @@ | |
|
||
buildGoModule rec { | ||
pname = "pulumi"; | ||
version = "3.122.0"; | ||
version = "3.137.0"; | ||
|
||
src = fetchFromGitHub { | ||
owner = pname; | ||
repo = pname; | ||
rev = "v${version}"; | ||
hash = "sha256-5KHptoQliqPtJ6J5u23ZgRZOdO77BJhZbdc3Cty9Myk="; | ||
hash = "sha256-U1BubJIqQu+tAYQz8ojVrJpx6ZbMFEarSCmmuahG6ys="; | ||
# Some tests rely on checkout directory name | ||
name = "pulumi"; | ||
}; | ||
|
||
vendorHash = "sha256-1UyYbmNNHlAeaW6M6AkaQ5Hs25ziHenSs4QjlnUQGjs="; | ||
|
||
patches = [ | ||
# Fix a test failure, can be dropped in next release (3.100.0) | ||
(fetchpatch { | ||
url = "https://github.com/pulumi/pulumi/commit/6dba7192d134d3b6f7e26dee9205711ccc736fa7.patch"; | ||
hash = "sha256-QRN6XnIR2rrqJ4UFYNt/YmIlokTSkGUvnBO/Q9UN8X8="; | ||
stripLen = 1; | ||
}) | ||
]; | ||
vendorHash = "sha256-Q9NTlgd+rOD5vmbmeAepIARvFtNQT/IFLPeaFC74E7c="; | ||
|
||
sourceRoot = "${src.name}/pkg"; | ||
|
||
|
@@ -62,18 +53,20 @@ buildGoModule rec { | |
ldflags=''${ldflags//"$importpathFlags"/} | ||
|
||
# Create some placeholders for plugins used in tests. Otherwise, Pulumi | ||
# tries to donwload them and fails, resulting in really long test runs | ||
dummyPluginPath=$(mktemp -d) | ||
# tries to donwload them and fails, resulting in really long test runs. | ||
# This has to be linked to the cwd, otherwise tests will fail and a | ||
# warning will be emitted noting that the plugin was located in $PATH. | ||
for name in pulumi-{resource-pkg{A,B},-pkgB}; do | ||
ln -s ${coreutils}/bin/true "$dummyPluginPath/$name" | ||
ln -s ${coreutils}/bin/true "$name" | ||
done | ||
|
||
export PATH=$dummyPluginPath''${PATH:+:}$PATH | ||
|
||
# Code generation tests also download dependencies from network | ||
rm codegen/{docs,dotnet,go,nodejs,python,schema}/*_test.go | ||
# Azure tests are not being skipped when an Azure token is not provided | ||
rm secrets/cloud/azure_test.go | ||
rm -R codegen/{dotnet,go,nodejs,python}/gen_program_test | ||
|
||
unset PULUMI_ACCESS_TOKEN | ||
'' + lib.optionalString stdenv.hostPlatform.isDarwin '' | ||
export PULUMI_HOME=$(mktemp -d) | ||
''; | ||
|
@@ -103,6 +96,14 @@ buildGoModule rec { | |
# +aws | ||
"TestPluginMapper_MappedNamesDifferFromPulumiName" | ||
"TestProtect" | ||
"TestProgressEvents" | ||
# This test depends on having a PULUMI_ACCESS_TOKEN but is not skipped when one is not provided. | ||
# Other tests are skipped when the env var is missing. I guess they forgot about this one. | ||
"TestPulumiNewSetsTemplateTag/python" | ||
# Both tests require having a "pulumi-language-yaml" plugin installed since pulumi/pulumi#17285, | ||
# which I'm not sure how to add. | ||
"TestProjectNameDefaults" | ||
"TestProjectNameOverrides" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pulumi tests are very flaky. |
||
]; | ||
in | ||
[ "-skip=^${lib.concatStringsSep "$|^" disabledTests}$" ]; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to ideas on how else to do this