bindiff: 8-unstable-2024-11-11, binexport: 12-unstable-2024-11-01 #355232
Conversation
ofborg
bot
added
8.has: package (new)
pluiedev
force-pushed
the
push-zyupwlxtuwmw
branch
from
b9e8247 to
ff07c69
Compare
| ''; | ||
| homepage = "https://github.com/google/binexport"; | ||
| license = with lib.licenses; [ asl20 ]; | ||
| platforms = with lib.platforms; lib.intersectLists x86 (unix ++ windows); |
There was a problem hiding this comment.
The issue with architectures only contrains ida-pro. I believe binexport and bindiff and binaryninja-api can be compiled on all platforms (linux, windows, macos).
Other than that, I'd be happy to approve this PR.
There was a problem hiding this comment.
Hmm. I wonder then should we just set the platforms for ida-sdk_8 to be x86(-64)-only, and have it automatically fail if evaluated on a non-x86 platform?
There was a problem hiding this comment.
Not entirely sure if this PR is hung up on anything else, but fwiw I think setting ida-sdk_8 to x86(-64)-only and only failing for it seems reasonable to me. Looking forward to this and eventual ghidra extension support making it's way in!
| mv $out/bindiff-prefix/bindiff*_ida*${sharedLibrary} $out/lib | ||
| '' | ||
| + '' | ||
| rmdir $out/bindiff-prefix |
There was a problem hiding this comment.
This fails on darwin:
rmdir: failed to remove '/nix/store/vgac29rqh53yrxz6jagvnx3qs7y61yah-bindiff-8-unstable-2024-11-11/bindiff-prefix': Directory not empty
Edit:
The lines before that might be relevant:
-- Install configuration: "Release"
-- Installing: /nix/store/vgac29rqh53yrxz6jagvnx3qs7y61yah-bindiff-8-unstable-2024-11-11/bindiff-prefix/bindiff
-- Installing: /nix/store/vgac29rqh53yrxz6jagvnx3qs7y61yah-bindiff-8-unstable-2024-11-11/bindiff-prefix/bindiff_config_setup
-- Installing: /nix/store/vgac29rqh53yrxz6jagvnx3qs7y61yah-bindiff-8-unstable-2024-11-11/bindiff-prefix/bindiff_launcher_macos
|
Nothing add, just: Thank you for working on this! |
Closes #257478
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.