Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bindiff: 8-unstable-2024-11-11, binexport: 12-unstable-2024-11-01 #355232
base: master
Are you sure you want to change the base?
bindiff: 8-unstable-2024-11-11, binexport: 12-unstable-2024-11-01 #355232
Changes from all commits
678e5ab
a254a9e
ff07c69
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails on darwin:
Edit:
The lines before that might be relevant:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue with architectures only contrains ida-pro. I believe binexport and bindiff and binaryninja-api can be compiled on all platforms (linux, windows, macos).
Other than that, I'd be happy to approve this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I wonder then should we just set the platforms for
ida-sdk_8
to be x86(-64)-only, and have it automatically fail if evaluated on a non-x86 platform?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¯\_(ツ)_/¯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure if this PR is hung up on anything else, but fwiw I think setting ida-sdk_8 to x86(-64)-only and only failing for it seems reasonable to me. Looking forward to this and eventual ghidra extension support making it's way in!