Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gradle: 8.10.2 -> 8.12 #356109

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

gradle: 8.10.2 -> 8.12 #356109

wants to merge 9 commits into from
+515 −486

Conversation

liff
Copy link
Contributor

@liff liff commented Nov 15, 2024 •
edited
Loading

Gradle release 8.12

Turns out the update script couldn’t deal with an update to .0. Even though the tag is v8.11.0 the actual version number is 8.11.

Fixes #355951.

Incorporates changes from #364871.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

liff
liff commented Nov 15, 2024
View reviewed changes
pkgs/development/tools/build-managers/gradle/default.nix Outdated
# Gradle’s .0 releases are tagged as `vX.Y.0`, but the actual
# release version omits the `.0`, so we’ll wanto to only capture
# the version up but not including the the trailing `.0`.
"--version-regex=^v(\\d+\\.\\d+(?:\\.[1-9]\\d?)?)(\\.0)?$"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now this’ll cause nix-update to crash, but I’ll open an issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mic92/nix-update#297

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to feel about including this flag while it's broken in upstream nix-update. Maybe we should comment it out and/or add it once it's fixed upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, commented out.

@liff liff mentioned this pull request Nov 15, 2024
Open
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Nov 15, 2024
@FliegendeWurst
Copy link
Member

jadx fails to build (succeeds on master)

FAILURE: Build failed with an exception.

* Where:
Build file '/build/source/buildSrc/build.gradle.kts' line: 1

* What went wrong:
Plugin [id: 'org.gradle.kotlin.kotlin-dsl', version: '5.1.1'] was not found in any of the following sources:

@liff
Copy link
Contributor Author

liff commented Nov 17, 2024

@FliegendeWurst thanks. It looks like since the MITM cache in #272380 we (may) have to run dependency update for Gradle-built packages.

I’ll run the updates and add refreshed deps.json for packages that need it.

@chayleaf
Copy link
Contributor

chayleaf commented Nov 18, 2024 •
edited
Loading

Each version of Gradle bundles different versions of various embedded stuff. There's not too much documentation on this, but from what I can tell the Kotlin DSL version is set here. It's further used here in code generation. Then, at build time, if the version doesn't match the hardcoded version, it may issue a warning here, but I don't see why it can't be overridden in theory.

Since this hardcoded version is likely possible to override, it's also possible to extend the Gradle build scripts to look for whatever Kotlin DSL plugin is in the cache and use that. Howver, Gradle docs say:

Each Gradle release is meant to be used with a specific version of the kotlin-dsl plugin and compatibility between arbitrary Gradle releases and kotlin-dsl plugin versions is not guaranteed. Using an unexpected version of the kotlin-dsl plugin in a build will emit a warning and can cause hard to diagnose problems.

I don't actually think the old FOD-style derivations would've avoided this issue, it seems unrelated to mitm-cache, but maybe Gradle has some weird logic where if a repo is local it uses whatever version is available instead of whatever version is set.

@liff liff changed the title gradle: 8.10.2 -> 8.11 gradle: 8.10.2 -> 8.11.1 Nov 20, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 25, 2024
@tomodachi94
Copy link
Member

Result of nixpkgs-review pr 356109 run on aarch64-linux 1

1 package marked as broken and skipped:
  • jextract
5 packages failed to build:
  • atlauncher
  • gscan2pdf
  • gscan2pdf.man
  • mindustry
  • mindustry-wayland
49 packages built:
  • apkeditor
  • apkleaks
  • apkleaks.dist
  • apksigcopier
  • apksigcopier.dist
  • apksigner
  • armitage
  • cie-middleware-linux
  • diffoscope
  • diffoscope.dist
  • diffoscope.man
  • experienced-pixel-dungeon
  • fdroidserver
  • fdroidserver.dist
  • garble
  • ghidra
  • ghidra-extensions.findcrypt
  • ghidra-extensions.ghidra-delinker-extension
  • ghidra-extensions.ghidra-golanganalyzerextension
  • ghidra-extensions.gnudisassembler
  • ghidra-extensions.lightkeeper
  • ghidra-extensions.machinelearning
  • ghidra-extensions.ret-sync
  • ghidra-extensions.sleighdevtools
  • gotenberg
  • gradle (gradle_8)
  • gradle-unwrapped (gradle_8-unwrapped)
  • jabref
  • jadx
  • openjfx23 (javaPackages.openjfx23)
  • jextract-21
  • key
  • kotlin-language-server
  • libeufin
  • mindustry-server
  • moneydance
  • mucommander
  • nextflow
  • nf-test
  • pdfchain
  • pdftk
  • pidginPackages.purple-signald
  • rat-king-adventure
  • rkpd2
  • shattered-pixel-dungeon
  • shorter-pixel-dungeon
  • signald
  • signaturepdf
  • summoning-pixel-dungeon

@tomodachi94
Copy link
Member

tomodachi94 commented Nov 26, 2024 •
edited
Loading

All of those build failures are already known:

@github-actions github-actions bot added the 6.topic: java Including JDK, tooling, other languages, other VMs label Dec 10, 2024
@wegank wegank removed 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 10, 2024
@ofborg ofborg bot requested a review from FliegendeWurst December 11, 2024 16:09
@msfjarvis msfjarvis mentioned this pull request Dec 13, 2024
Closed
13 tasks
@liff liff changed the title gradle: 8.10.2 -> 8.11.1 gradle: 8.10.2 -> 8.12 Dec 23, 2024
@lorenzleutgeb lorenzleutgeb added 8.has: package (update) This PR updates a package to a newer version 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 23, 2024
@lorenzleutgeb
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356109

x86_64-linux

⏩ 1 package marked as broken and skipped:
  • jextract
❌ 43 packages failed to build:
  • anyk
  • autopsy
  • bisq2
  • bluej
  • corretto11
  • corretto11.debug
  • corretto17
  • corretto17.debug
  • corretto21
  • corretto21.debug
  • cryptomator
  • ganttproject-bin
  • ghidra
  • ghidra-extensions.findcrypt
  • ghidra-extensions.ghidra-delinker-extension
  • ghidra-extensions.ghidra-golanganalyzerextension
  • ghidra-extensions.gnudisassembler
  • ghidra-extensions.lightkeeper
  • ghidra-extensions.machinelearning
  • ghidra-extensions.ret-sync
  • ghidra-extensions.sleighdevtools
  • ghidra-extensions.wasm
  • gotenberg
  • greenfoot
  • gscan2pdf
  • gscan2pdf.man
  • jabref
  • keyboard-layout-editor
  • keyguard
  • mcaselector
  • minion
  • moneydance
  • ns-usbloader
  • pattypan
  • pdfsam-basic
  • quark-goldleaf
  • scenebuilder
  • scenic-view
  • slimevr
  • slimevr-server
  • sparrow
  • sparrow-unwrapped
  • sportstracker
✅ 56 packages built:
  • apkeditor
  • apkleaks
  • apkleaks.dist
  • apksigcopier
  • apksigcopier.dist
  • apksigner
  • armitage
  • atlauncher
  • cie-middleware-linux
  • diffoscope
  • diffoscope.dist
  • diffoscope.man
  • experienced-pixel-dungeon
  • fastddsgen
  • fdroidserver
  • fdroidserver.dist
  • freenet
  • freeplane
  • garble
  • gradle (gradle_8)
  • gradle-unwrapped
  • gradle_7
  • gradle_7-unwrapped
  • jadx
  • java-hamcrest
  • javaPackages.openjfx17
  • javaPackages.openjfx21
  • javaPackages.openjfx23
  • jextract-21
  • key
  • keyspersecond
  • kotlin-language-server
  • libeufin
  • maptool
  • marytts
  • microsoft-identity-broker
  • mindustry
  • mindustry-server
  • mindustry-wayland
  • mucommander
  • nextflow
  • nf-test
  • olvid
  • pdfchain
  • pdftk
  • pidginPackages.purple-signald
  • quake-injector
  • rat-king-adventure
  • rkpd2
  • shattered-pixel-dungeon
  • shorter-pixel-dungeon
  • signald
  • signaturepdf
  • stirling-pdf
  • summoning-pixel-dungeon
  • tower-pixel-dungeon

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 23, 2024
@ofborg ofborg bot requested a review from lorenzleutgeb December 23, 2024 21:43
@chayleaf
Copy link
Contributor

that's a lot of build failures, was there a breaking change in Gradle?

@liff
Copy link
Contributor Author

liff commented Dec 27, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356109

x86_64-linux

⏩ 1 package marked as broken and skipped:
  • jextract
❌ 15 packages failed to build:
  • cie-middleware-linux
  • ghidra
  • ghidra-extensions.findcrypt
  • ghidra-extensions.ghidra-delinker-extension
  • ghidra-extensions.ghidra-golanganalyzerextension
  • ghidra-extensions.gnudisassembler
  • ghidra-extensions.lightkeeper
  • ghidra-extensions.machinelearning
  • ghidra-extensions.ret-sync
  • ghidra-extensions.sleighdevtools
  • ghidra-extensions.wasm
  • gscan2pdf
  • gscan2pdf.man
  • jabref
  • pidginPackages.purple-signald
✅ 84 packages built:
  • anyk
  • apkeditor
  • apkleaks
  • apkleaks.dist
  • apksigcopier
  • apksigcopier.dist
  • apksigner
  • armitage
  • atlauncher
  • autopsy
  • bisq2
  • bluej
  • corretto11
  • corretto11.debug
  • corretto17
  • corretto17.debug
  • corretto21
  • corretto21.debug
  • cryptomator
  • diffoscope
  • diffoscope.dist
  • diffoscope.man
  • experienced-pixel-dungeon
  • fastddsgen
  • fdroidserver
  • fdroidserver.dist
  • freenet
  • freeplane
  • ganttproject-bin
  • garble
  • gotenberg
  • gradle (gradle_8)
  • gradle-unwrapped
  • gradle_7
  • gradle_7-unwrapped
  • greenfoot
  • jadx
  • java-hamcrest
  • javaPackages.openjfx17
  • javaPackages.openjfx21
  • javaPackages.openjfx23
  • jextract-21
  • key
  • keyboard-layout-editor
  • keyguard
  • keyspersecond
  • kotlin-language-server
  • libeufin
  • maptool
  • marytts
  • mcaselector
  • microsoft-identity-broker
  • mindustry
  • mindustry-server
  • mindustry-wayland
  • minion
  • moneydance
  • mucommander
  • nextflow
  • nf-test
  • ns-usbloader
  • olvid
  • pattypan
  • pdfchain
  • pdfsam-basic
  • pdftk
  • quake-injector
  • quark-goldleaf
  • rat-king-adventure
  • rkpd2
  • scenebuilder
  • scenic-view
  • shattered-pixel-dungeon
  • shorter-pixel-dungeon
  • signald
  • signaturepdf
  • slimevr
  • slimevr-server
  • sparrow
  • sparrow-unwrapped
  • sportstracker
  • stirling-pdf
  • summoning-pixel-dungeon
  • tower-pixel-dungeon

@liff
Copy link
Contributor Author

liff commented Dec 27, 2024

Ghidra build fails at :Debugger-rmi-trace:buildPyPackage when running pip, but I haven’t been able to figure out why.

@chayleaf
Copy link
Contributor

CC @roblabla @vringar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Infinidoge Infinidoge Awaiting requested review from Infinidoge

@chayleaf chayleaf Awaiting requested review from chayleaf

@tomodachi94 tomodachi94 Awaiting requested review from tomodachi94

@FliegendeWurst FliegendeWurst Awaiting requested review from FliegendeWurst

@lorenzleutgeb lorenzleutgeb Awaiting requested review from lorenzleutgeb

Assignees
No one assigned
Labels
6.topic: java Including JDK, tooling, other languages, other VMs 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: gradle_8 8.10.x → 8.11
7 participants
@liff @FliegendeWurst @chayleaf @tomodachi94 @lorenzleutgeb @wegank @msfjarvis