gradle: add support for the new file events library #364871
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle 8.12 (currently in release candidate phase) switches from the old file-events library to a new one that has a different name. The update is yet to land in Nixpkgs but this prepares us in advance.
I've tested that I can build Gradle 8.12 RC1 with this change by adding the following to
all-packages.nix
:I've also confirmed that Gradle 7 and 8 continue to build as before, I have
nixpkgs-review
still running just in case I've angered the gods somehow.Looks like this PR will conflict with #356109 so I'm okay to wait it out if that is going to be merged soon.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.