Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle: add support for the new file events library #364871

Closed
wants to merge 2 commits into from

Conversation

msfjarvis
Copy link
Contributor

@msfjarvis msfjarvis commented Dec 13, 2024

Gradle 8.12 (currently in release candidate phase) switches from the old file-events library to a new one that has a different name. The update is yet to land in Nixpkgs but this prepares us in advance.

I've tested that I can build Gradle 8.12 RC1 with this change by adding the following to all-packages.nix:

gradle_8_12 = wrapGradle (callPackage (gradleGen { version = "8.12-rc-1"; hash = "sha256-TZ161M+IQvJ5ZJIT0vh9j36aA651rEOJUXqldLFASyo="; defaultJava = jdk23; }) {}) null;

I've also confirmed that Gradle 7 and 8 continue to build as before, I have nixpkgs-review still running just in case I've angered the gods somehow.

Looks like this PR will conflict with #356109 so I'm okay to wait it out if that is going to be merged soon.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 16, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 18, 2024
@msfjarvis
Copy link
Contributor Author

Gradle 8.12 is out now so this is required to use pkgs.gradleGen out of tree as well, is there anything blocking the merging of the PR?

@liff liff mentioned this pull request Dec 23, 2024
13 tasks
@liff
Copy link
Contributor

liff commented Dec 23, 2024

I’ve cherry-picked these changes into #356109.

@msfjarvis
Copy link
Contributor Author

Thanks! Closing since it's superseded by #356109

@msfjarvis msfjarvis closed this Dec 23, 2024
@msfjarvis msfjarvis deleted the hs/gradle-8-12-compat branch December 23, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: java Including JDK, tooling, other languages, other VMs 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants