-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet-{sdk,runtime,aspnetcore}_{6,7}: mark as EOL #358533
Conversation
This should be backported to 24.05 too, but the more pressing issue there is that it seems like even security updates for the in‐support versions were not backported throughout the release cycle. |
Is
This is probably my fault for not being on top of backports. Should I make a PR specifically to backport the updates with minimal changes? |
Hydra doesn’t build insecure packages except for rare exceptions, so packages using these versions won’t be cached, yes. They’ll have to be migrated to supported releases but given the complexity and large attack surface of .NET and upstream’s stated support policies we shouldn’t hold off on marking these before they can be removed, in line with how we handle EOL Node.js and JDK versions. Backporting the updates of the newer versions to 25.05 would be great, although I don’t know if there have been severe CVEs or not and we only support 25.05 for about another month anyway. |
I'm a little worried about what's going to get caught up in this. For example,
I guess it has components that target And then there's things like:
Which aren't covered by this PR, but probably should be. I'm actually working on a treewide change to stop using For example, I believe:
will be needed for anything that targets |
I’m worried about the blast radius too, but – .NET 6 has been end‐of‐life for half a year now, we can’t release 24.11 in a week’s time with versions of a complex JIT runtime that don’t have upstream security support and in the case of .NET 6 surely have known security issues that would have been fixed if they weren’t EOL. I’m not an expert in .NET, of course, so I’m not very well‐placed to coordinate a mass migration, but all the packages will still be possible to use past the security warning and migrating packages to supported versions can happen afterwards. Generally we try to remove stuff that is going to go EOL earlier in the release process than this, but I think nobody was aware of the situation here until it was brought up on Matrix. As far as the targeting packages go – are those basically just interface definitions? I think those are fine, since in practice they’ll be running on a runtime that we can support. |
Yeah, that's right. I agree, it just might slightly complicate how we tag things from nuget as EOL. I'm not against merging this. There aren't a lot of inter-dependencies in the dotnet packages, so most of them build relatively quickly. I'll try to get rid of the unnecessary runtime/sdk dependencies in the near future. |
Yeah, no worries :) Feel free to ping me for review on any PRs dealing with the fallout here – hopefully there won’t be anything too major by the time of the 24.11 release. |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-358533-to-release-24.11 origin/release-24.11
cd .worktree/backport-358533-to-release-24.11
git switch --create backport-358533-to-release-24.11
git cherry-pick -x 3561b1dd74cc672a43c4cc9b59a2ccc196dc8d21 |
Successfully created backport PR for |
I added a comment here: 65589ee#commitcomment-149808683, but I guess this is a better place for it. I have been searching far and wide, but I am still unsure how to properly handle this change. (
with pkgs.dotnetCorePackages;
combinePackages [
sdk_9_0
sdk_8_0_3xx
- sdk_6_0_1xx
]
) But I am met with
Anything to help me out or point me in the right direction? |
You are supposed to apply the environment variable and run the command with |
That was a typo, I was using |
You shouldn't be seeing this after removing all references to 6/7. Maybe I don't understand exactly what you're doing. Could you share the command used to reproduce it? |
A simple |
Any chance you can get a full trace ( |
Ahh yes, |
See https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.