Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mautrix-signal: 0.7.2 -> 0.7.3 #358785

Merged
merged 2 commits into from
Nov 25, 2024
Merged

mautrix-signal: 0.7.2 -> 0.7.3 #358785

merged 2 commits into from
Nov 25, 2024

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 24, 2024

ChangeLog: https://github.com/mautrix/signal/releases/tag/v0.7.3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Ma27 Ma27 requested a review from niklaskorz November 24, 2024 18:48
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 24, 2024
@Ma27 Ma27 marked this pull request as ready for review November 24, 2024 18:51
@niklaskorz
Copy link
Contributor

niklaskorz commented Nov 24, 2024

Seems to break decryption when goolm is enabled, but goolm is neither officially endorsed by us or upstream right now so that's not a blocker (goolm worked really well in 0.7.2 for me so far). Switching back to libolm and then testing again.

Edit: I can't decrypt without goolm either after updating, hm, will investigate if it's an issue in my setup

Edit 2: It was unrelated to the update and just caused by the update-related restart. I still had an active buggy Element X sessions that mautrix was encrypting for. Goolm still working fine!

@Ma27 Ma27 merged commit 0f9abba into NixOS:master Nov 25, 2024
19 of 20 checks passed
@Ma27 Ma27 deleted the bump-mautrix-signal branch November 25, 2024 07:33
@niklaskorz niklaskorz mentioned this pull request Dec 22, 2024
13 tasks
@nix-backports
Copy link

nix-backports bot commented Dec 22, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-358785-to-release-24.05 origin/release-24.05
cd .worktree/backport-358785-to-release-24.05
git switch --create backport-358785-to-release-24.05
git cherry-pick -x 576701eebceed7402943fa82e02bbce136d2d61a 705ae9b92e70c3abd0668c58ecee298127db188c

1 similar comment
@nix-backports
Copy link

nix-backports bot commented Dec 22, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-358785-to-release-24.05 origin/release-24.05
cd .worktree/backport-358785-to-release-24.05
git switch --create backport-358785-to-release-24.05
git cherry-pick -x 576701eebceed7402943fa82e02bbce136d2d61a 705ae9b92e70c3abd0668c58ecee298127db188c

@nix-backports
Copy link

nix-backports bot commented Dec 22, 2024

Git push to origin failed for release-24.11 with exitcode 1

@nix-backports
Copy link

nix-backports bot commented Dec 22, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants