-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strongswan: 5.9.14 -> 6.0.0 #362302
base: master
Are you sure you want to change the base?
strongswan: 5.9.14 -> 6.0.0 #362302
Conversation
@NickCao at first glance, LGTM. But I have two suggestions:
re 2) I tried manually hacking the current test-case to use strongswan_6 and it passes. So I believe it's just a matter of making actual support for package arg in the test. |
Let's do this in steps, first part: #372967 |
@johanot After weeks of use I feel strongswan 6 is mostly backwards compatible with strongswan 5, maybe there isn't that much a need to keep strongswan 5 around? |
Tbh I haven't really tried Strongswan 6 (yet) myself, which is partially why I wanted to improve the tests covering it (#370840). The code LGTM, I'd just like to be able to run the tests for all versions of the package (if we end up with more than one). As for whether to drop 5.9: I don't know the lifecycle of strongswan. Is 5.9 EOL soon? Or is 5.9 supported long-term side by side with 6.0? In the former case, I would just go "strongswan: 5.9 -> 6.0". In the latter case, we might do nixpkgs a favor of keeping both versions around. I promise to read up on the release cycle later, unless someone beats me to it here. |
I don't see the lifecycle/policy posted anywhere, let's just ask: strongswan/strongswan#2614 |
Update: the answer is no. |
I noticed that strongswan 5.x in nixpkgs does not enable EAP-PEAP. Should we add this flag before bringing it to v6 ? |
Already enabled in this PR. |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.