nixos/strongswan: improve testing of both swanctl and base strongswan module #370840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
johanot
force-pushed
the
strongswan-test
branch
from
18d502c to
1aff652
Compare
|
@GrahamcOfBorg test strongswan |
|
@ofborg test strongswan |
|
lucasew
approved these changes
Jan 4, 2025
wegank
added
the
12.approvals: 1
NickCao
reviewed
Jan 5, 2025
| @@ -81,6 +82,8 @@ in | |||
| options.services.strongswan = { | |||
| enable = mkEnableOption "strongSwan"; | |||
|
|
|||
| package = mkPackageOption pkgs "strongswan" { }; | |||
There was a problem hiding this comment.
Where is the package option used?
There was a problem hiding this comment.
It's not being used. The unit is referencing pkgs directly, and there is a with cfg there.
There was a problem hiding this comment.
It's not being used. The unit is referencing pkgs directly, and there is a with cfg there.
Then these pkgs.strongswan should be replaced with cfg.package.
There was a problem hiding this comment.
Indeed, thanks :) I just failed at git add -p
There was a problem hiding this comment.
it's fixed now: 25ecc0e
johanot
force-pushed
the
strongswan-test
branch
from
1aff652 to
4045bee
Compare
wegank
removed
the
12.approvals: 1
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to see #362302 and #370067 merged. But I would also like to improve testing before approving.
This PR:
cc @NickCao
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.