Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/networking-interfaces-scripted: use read -r #363434

Merged

Conversation

tomodachi94
Copy link
Member

...instead of plain read, which can cause issues.

See SC2162:
https://www.shellcheck.net/wiki/SC2162

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

...instead of plain read, which can cause issues.

See SC2162:
https://www.shellcheck.net/wiki/SC2162
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 9, 2024
@tomodachi94 tomodachi94 requested a review from bjornfor December 9, 2024 01:37
@bjornfor bjornfor merged commit 2e98ec0 into NixOS:master Dec 9, 2024
22 of 23 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 9, 2024

Successfully created backport PR for release-24.05:

@nix-backports
Copy link

nix-backports bot commented Dec 9, 2024

Successfully created backport PR for release-24.11:

@tomodachi94 tomodachi94 deleted the enhance/nixos/network-interfaces-scripted branch December 9, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants