Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] nixos/networking-interfaces-scripted: use read -r #363481

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

nixpkgs-ci[bot]
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Dec 9, 2024

Bot-based backport to release-24.11, triggered by a label in #363434.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

...instead of plain read, which can cause issues.

See SC2162:
https://www.shellcheck.net/wiki/SC2162

(cherry picked from commit 2e98ec0)
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 9, 2024
@NickCao NickCao merged commit 8ac152b into release-24.11 Dec 9, 2024
20 of 21 checks passed
@tomodachi94 tomodachi94 deleted the backport-363434-to-release-24.11 branch December 9, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants