Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libftdi1: fix build with swig 4.3.0 #364816

Merged
merged 2 commits into from
Dec 16, 2024
Merged

libftdi1: fix build with swig 4.3.0 #364816

merged 2 commits into from
Dec 16, 2024

Conversation

paparodeo
Copy link
Contributor

https://hydra.nixos.org/build/281790224

SWIG_Python_AppendOutput now takes 3 args. use the SWIG_AppendOutput macro which takes 2 args and fills in the 3rd.
https://bugzilla.redhat.com/show_bug.cgi?id=2319133
https://src.fedoraproject.org/rpms/libftdi/raw/9051ea9ea767eced58b69d855a5d700a5d4602cc/f/libftdi-1.5-swig-4.3.patch

postFixup code is unnecessary as the files contain correct paths so remove it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@paparodeo paparodeo changed the title libftdi1: fix build libftdi1: fix build with swig 4.3.0 Dec 13, 2024
@ofborg ofborg bot requested a review from bjornfor December 13, 2024 22:57
@bjornfor
Copy link
Contributor

Result of nixpkgs-review pr 364816 run on x86_64-linux 1

55 packages failed to build:
  • collectd
  • dvdstyler
  • geeqie
  • gjay
  • glasgow
  • glasgow.dist
  • indi-full-nonfree
  • kodi (kodiPackages.kodi)
  • kodi-gbm
  • kodi-wayland
  • kodiPackages.a4ksubtitles
  • kodiPackages.archive_tool
  • kodiPackages.iagl
  • kodiPackages.inputstream-adaptive
  • kodiPackages.inputstream-ffmpegdirect
  • kodiPackages.inputstream-rtmp
  • kodiPackages.invidious
  • kodiPackages.joystick
  • kodiPackages.kodi-platform
  • kodiPackages.libretro
  • kodiPackages.libretro-2048
  • kodiPackages.libretro-fuse
  • kodiPackages.libretro-genplus
  • kodiPackages.libretro-mgba
  • kodiPackages.libretro-nestopia
  • kodiPackages.libretro-snes9x
  • kodiPackages.netflix
  • kodiPackages.orftvthek
  • kodiPackages.pvr-hdhomerun
  • kodiPackages.pvr-hts
  • kodiPackages.pvr-iptvsimple
  • kodiPackages.pvr-vdr-vnsi
  • kodiPackages.steam-controller
  • kodiPackages.vfs-libarchive
  • kodiPackages.vfs-rar
  • kodiPackages.vfs-sftp
  • kodiPackages.visualization-fishbmc
  • kodiPackages.visualization-goom
  • kodiPackages.visualization-matrix
  • kodiPackages.visualization-pictureit
  • kodiPackages.visualization-projectm
  • kodiPackages.visualization-shadertoy
  • kodiPackages.visualization-spectrum
  • kodiPackages.visualization-starburst
  • kodiPackages.visualization-waveform
  • kodiPackages.youtube
  • nextpnr
  • nextpnrWithGui
  • ola
  • python312Packages.brainflow
  • python312Packages.brainflow.dist
  • python313Packages.brainflow
  • python313Packages.brainflow.dist
  • qlcplus
  • tinygo
60 packages built:
  • arachne-pnr
  • audacious
  • audacious-plugins
  • avrdude
  • avrdudess
  • blackmagic
  • brainflow
  • fbida
  • fgallery
  • flashprog
  • flashrom
  • fujprog
  • fw-ectool
  • icestorm
  • indi-3rdparty.indi-mgen
  • indi-3rdparty.indi-nightscape
  • indi-3rdparty.indi-qsi
  • jtag-remote-server
  • klipper-firmware
  • klipper-flash
  • libexsid
  • libexsid.doc
  • libftdi1
  • libsidplayfp
  • libsidplayfp.doc
  • libsigrok
  • lirc (python312Packages.lirc)
  • openfpgaloader
  • openocd
  • openocd-rp2040
  • opentx
  • paprefs
  • pulseaudioFull
  • pulseaudioFull.dev
  • pulseview
  • python312Packages.pylibftdi
  • python312Packages.pylibftdi.dist
  • python312Packages.sigrok
  • python313Packages.lirc
  • python313Packages.pylibftdi
  • python313Packages.pylibftdi.dist
  • python313Packages.sigrok
  • qmk
  • qmk.dist
  • qmmp
  • qmplay2 (qmplay2-qt6)
  • qmplay2-qt5
  • raspberrypi-eeprom
  • ravedude
  • rhythmbox
  • rosegarden
  • sd-mux-ctrl
  • sidplayfp
  • sigrok-cli
  • smuview
  • urjtag
  • xine-ui
  • xine-ui.dev
  • xine-ui.lib
  • xine-ui.man

@bjornfor
Copy link
Contributor

55 packages failed to build:

That's suspicious. I'll re-run and check the base branch.

@bjornfor
Copy link
Contributor

55 packages failed to build:

That's suspicious. I'll re-run and check the base branch.

Same result. Only now did I notice that this targets staging-next. It seems that branch is just that broken now.

Since it's not that many rebuilds, I think you can mark this PR as a draft, re-target onto master, and then un-draft. (Temporarily using draft should prevent mass notifications.)

@paparodeo paparodeo changed the base branch from staging-next to master December 14, 2024 11:22
@paparodeo paparodeo force-pushed the libftdi1-fix branch 2 times, most recently from 092c26f to af9a39b Compare December 14, 2024 11:23
@paparodeo paparodeo closed this Dec 14, 2024
@paparodeo paparodeo deleted the libftdi1-fix branch December 14, 2024 11:25
@paparodeo paparodeo restored the libftdi1-fix branch December 15, 2024 04:29
@paparodeo
Copy link
Contributor Author

so it seems to me like the failures are due to lirc which for some reason builds on hydra correctly but when trying nix-build -A lirc --check on master fails.

make[3]: Nothing to be done for 'install-exec-am'.
 /nix/store/b1wvkjx96i3s7wblz38ya0zr8i93zbc5-coreutils-9.5/bin/mkdir -p '/lib/systemd/system'
/nix/store/b1wvkjx96i3s7wblz38ya0zr8i93zbc5-coreutils-9.5/bin/mkdir: cannot create directory '/lib': Permission denied
make[3]: *** [Makefile:370: install-dist_systemdsystemunitDATA] Error 1

but on hydra it is creating a directory in the nix store.
https://cache.nixos.org/log/s5d104skq1w1f611rd784xnd2jnmq8mc-lirc-0.10.2.drv

anyway -- doesn't seem like it has anything to do with this change or staging-next unfortunately.

@bjornfor
Copy link
Contributor

So, let's re-open the PR?

@paparodeo paparodeo reopened this Dec 15, 2024
@paparodeo
Copy link
Contributor Author

so it seems to me like the failures are due to lirc which for some reason builds on hydra correctly but when trying nix-build -A lirc --check on master fails.

looking at lirc more it seems that the failure is due to autoconf looking in /proc/versions for Ubuntu and overriding a configuration value which then will cause the build to fail. was able to fix the build on ubuntu with #365491

with that patch for lirc everything builds fine.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

x86_64-linux

✅ 115 packages built:
  • arachne-pnr
  • audacious
  • audacious-plugins
  • avrdude
  • avrdudess
  • blackmagic
  • brainflow
  • collectd
  • dvdstyler
  • fbida
  • fgallery
  • flashprog
  • flashrom
  • fujprog
  • fw-ectool
  • geeqie
  • gjay
  • glasgow
  • glasgow.dist
  • icestorm
  • indi-3rdparty.indi-mgen
  • indi-3rdparty.indi-nightscape
  • indi-3rdparty.indi-qsi
  • indi-full-nonfree
  • jtag-remote-server
  • klipper-firmware
  • klipper-flash
  • kodi (kodiPackages.kodi)
  • kodi-gbm
  • kodi-wayland
  • kodiPackages.a4ksubtitles
  • kodiPackages.archive_tool
  • kodiPackages.iagl
  • kodiPackages.inputstream-adaptive
  • kodiPackages.inputstream-ffmpegdirect
  • kodiPackages.inputstream-rtmp
  • kodiPackages.invidious
  • kodiPackages.joystick
  • kodiPackages.kodi-platform
  • kodiPackages.libretro
  • kodiPackages.libretro-2048
  • kodiPackages.libretro-fuse
  • kodiPackages.libretro-genplus
  • kodiPackages.libretro-mgba
  • kodiPackages.libretro-nestopia
  • kodiPackages.libretro-snes9x
  • kodiPackages.netflix
  • kodiPackages.orftvthek
  • kodiPackages.pvr-hdhomerun
  • kodiPackages.pvr-hts
  • kodiPackages.pvr-iptvsimple
  • kodiPackages.pvr-vdr-vnsi
  • kodiPackages.steam-controller
  • kodiPackages.vfs-libarchive
  • kodiPackages.vfs-rar
  • kodiPackages.vfs-sftp
  • kodiPackages.visualization-fishbmc
  • kodiPackages.visualization-goom
  • kodiPackages.visualization-matrix
  • kodiPackages.visualization-pictureit
  • kodiPackages.visualization-projectm
  • kodiPackages.visualization-shadertoy
  • kodiPackages.visualization-spectrum
  • kodiPackages.visualization-starburst
  • kodiPackages.visualization-waveform
  • kodiPackages.youtube
  • libexsid
  • libexsid.doc
  • libftdi1
  • libsidplayfp
  • libsidplayfp.doc
  • libsigrok
  • lirc (python312Packages.lirc)
  • nextpnr
  • nextpnrWithGui
  • ola
  • openfpgaloader
  • openocd
  • openocd-rp2040
  • opentx
  • paprefs
  • pulseaudioFull
  • pulseaudioFull.dev
  • pulseview
  • python311Packages.brainflow
  • python311Packages.brainflow.dist
  • python311Packages.lirc
  • python311Packages.pylibftdi
  • python311Packages.pylibftdi.dist
  • python311Packages.sigrok
  • python312Packages.brainflow
  • python312Packages.brainflow.dist
  • python312Packages.pylibftdi
  • python312Packages.pylibftdi.dist
  • python312Packages.sigrok
  • qlcplus
  • qmk
  • qmk.dist
  • qmmp
  • qmplay2 (qmplay2-qt6)
  • qmplay2-qt5
  • raspberrypi-eeprom
  • ravedude
  • rhythmbox
  • rosegarden
  • sd-mux-ctrl
  • sidplayfp
  • sigrok-cli
  • smuview
  • tinygo
  • urjtag
  • xine-ui
  • xine-ui.dev
  • xine-ui.lib
  • xine-ui.man

@paparodeo paparodeo mentioned this pull request Dec 16, 2024
Merged
13 tasks
@paparodeo
Copy link
Contributor Author

rebased on master to pickup #365491 and then ran nixpkgs-review on the PR

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364816

x86_64-linux

✅ 115 packages built:
  • arachne-pnr
  • audacious
  • audacious-plugins
  • avrdude
  • avrdudess
  • blackmagic
  • brainflow
  • collectd
  • dvdstyler
  • fbida
  • fgallery
  • flashprog
  • flashrom
  • fujprog
  • fw-ectool
  • geeqie
  • gjay
  • glasgow
  • glasgow.dist
  • icestorm
  • indi-3rdparty.indi-mgen
  • indi-3rdparty.indi-nightscape
  • indi-3rdparty.indi-qsi
  • indi-full-nonfree
  • jtag-remote-server
  • klipper-firmware
  • klipper-flash
  • kodi (kodiPackages.kodi)
  • kodi-gbm
  • kodi-wayland
  • kodiPackages.a4ksubtitles
  • kodiPackages.archive_tool
  • kodiPackages.iagl
  • kodiPackages.inputstream-adaptive
  • kodiPackages.inputstream-ffmpegdirect
  • kodiPackages.inputstream-rtmp
  • kodiPackages.invidious
  • kodiPackages.joystick
  • kodiPackages.kodi-platform
  • kodiPackages.libretro
  • kodiPackages.libretro-2048
  • kodiPackages.libretro-fuse
  • kodiPackages.libretro-genplus
  • kodiPackages.libretro-mgba
  • kodiPackages.libretro-nestopia
  • kodiPackages.libretro-snes9x
  • kodiPackages.netflix
  • kodiPackages.orftvthek
  • kodiPackages.pvr-hdhomerun
  • kodiPackages.pvr-hts
  • kodiPackages.pvr-iptvsimple
  • kodiPackages.pvr-vdr-vnsi
  • kodiPackages.steam-controller
  • kodiPackages.vfs-libarchive
  • kodiPackages.vfs-rar
  • kodiPackages.vfs-sftp
  • kodiPackages.visualization-fishbmc
  • kodiPackages.visualization-goom
  • kodiPackages.visualization-matrix
  • kodiPackages.visualization-pictureit
  • kodiPackages.visualization-projectm
  • kodiPackages.visualization-shadertoy
  • kodiPackages.visualization-spectrum
  • kodiPackages.visualization-starburst
  • kodiPackages.visualization-waveform
  • kodiPackages.youtube
  • libexsid
  • libexsid.doc
  • libftdi1
  • libsidplayfp
  • libsidplayfp.doc
  • libsigrok
  • lirc (python312Packages.lirc)
  • nextpnr
  • nextpnrWithGui
  • ola
  • openfpgaloader
  • openocd
  • openocd-rp2040
  • opentx
  • paprefs
  • pulseaudioFull
  • pulseaudioFull.dev
  • pulseview
  • python311Packages.brainflow
  • python311Packages.brainflow.dist
  • python311Packages.lirc
  • python311Packages.pylibftdi
  • python311Packages.pylibftdi.dist
  • python311Packages.sigrok
  • python312Packages.brainflow
  • python312Packages.brainflow.dist
  • python312Packages.pylibftdi
  • python312Packages.pylibftdi.dist
  • python312Packages.sigrok
  • qlcplus
  • qmk
  • qmk.dist
  • qmmp
  • qmplay2 (qmplay2-qt6)
  • qmplay2-qt5
  • raspberrypi-eeprom
  • ravedude
  • rhythmbox
  • rosegarden
  • sd-mux-ctrl
  • sidplayfp
  • sigrok-cli
  • smuview
  • tinygo
  • urjtag
  • xine-ui
  • xine-ui.dev
  • xine-ui.lib
  • xine-ui.man

bjornfor
bjornfor approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjornfor bjornfor merged commit a9a3e34 into NixOS:master Dec 16, 2024
23 of 24 checks passed
@paparodeo paparodeo deleted the libftdi1-fix branch December 16, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paparodeo @bjornfor