Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lirc: fix build on ubuntu #365491

Merged
merged 1 commit into from
Dec 16, 2024
Merged

lirc: fix build on ubuntu #365491

merged 1 commit into from
Dec 16, 2024

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Dec 16, 2024 •
edited
Loading

autoconf looks in /proc/version for Ubuntu and on match overrides the --with-systemdsystemunitdir value set in configureFlags causing the build to fail.

mkdir -p '/lib/systemd/system'
mkdir: cannot create directory '/lib': Permission denied

patch configure.ac to prevent the override when building on ubuntu

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@paparodeo paparodeo mentioned this pull request Dec 16, 2024
Merged
13 tasks
@paparodeo
Copy link
Contributor Author

paparodeo commented Dec 16, 2024 •
edited
Loading

ran nixpkgs-review as part of another PR and everything passed. #364816 (comment)

[edit] ran on this PR only as well.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365491

x86_64-linux

✅ 57 packages built:
  • audacious
  • audacious-plugins
  • dvdstyler
  • fbida
  • fgallery
  • geeqie
  • gjay
  • kodi (kodiPackages.kodi)
  • kodi-gbm
  • kodi-wayland
  • kodiPackages.a4ksubtitles
  • kodiPackages.archive_tool
  • kodiPackages.iagl
  • kodiPackages.inputstream-adaptive
  • kodiPackages.inputstream-ffmpegdirect
  • kodiPackages.inputstream-rtmp
  • kodiPackages.invidious
  • kodiPackages.joystick
  • kodiPackages.kodi-platform
  • kodiPackages.libretro
  • kodiPackages.libretro-2048
  • kodiPackages.libretro-fuse
  • kodiPackages.libretro-genplus
  • kodiPackages.libretro-mgba
  • kodiPackages.libretro-nestopia
  • kodiPackages.libretro-snes9x
  • kodiPackages.netflix
  • kodiPackages.orftvthek
  • kodiPackages.pvr-hdhomerun
  • kodiPackages.pvr-hts
  • kodiPackages.pvr-iptvsimple
  • kodiPackages.pvr-vdr-vnsi
  • kodiPackages.steam-controller
  • kodiPackages.vfs-libarchive
  • kodiPackages.vfs-rar
  • kodiPackages.vfs-sftp
  • kodiPackages.visualization-fishbmc
  • kodiPackages.visualization-goom
  • kodiPackages.visualization-matrix
  • kodiPackages.visualization-pictureit
  • kodiPackages.visualization-projectm
  • kodiPackages.visualization-shadertoy
  • kodiPackages.visualization-spectrum
  • kodiPackages.visualization-starburst
  • kodiPackages.visualization-waveform
  • kodiPackages.youtube
  • lirc (python312Packages.lirc)
  • paprefs
  • pulseaudioFull
  • pulseaudioFull.dev
  • python311Packages.lirc
  • rhythmbox
  • rosegarden
  • xine-ui
  • xine-ui.dev
  • xine-ui.lib
  • xine-ui.man

@winterqt winterqt requested a review from pSub December 16, 2024 04:31
@winterqt winterqt added the backport release-24.11 Backport PR automatically label Dec 16, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Dec 16, 2024
winterqt
winterqt approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible. Maybe worth proposing upstream if this is ancient hackery...?

@paparodeo
Copy link
Contributor Author

Incredible. Maybe worth proposing upstream if this is ancient hackery...?

created a ticket: https://sourceforge.net/p/lirc/tickets/385/

@paparodeo
lirc: fix build on ubuntu
d8e708a 
autoconf looks in /proc/version for `Ubuntu` and on match overrides the
`--with-systemdsystemunitdir` value set in `configureFlags` causing the
build to fail.

> mkdir -p '/lib/systemd/system'
> mkdir: cannot create directory '/lib': Permission denied

patch `configure.ac` to prevent the override when building on ubuntu
@bjornfor bjornfor merged commit 3348c12 into NixOS:master Dec 16, 2024
23 of 24 checks passed
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Dec 16, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 16, 2024
Merged
1 task
@paparodeo paparodeo deleted the lirc-ubuntu-fix branch December 16, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winterqt winterqt winterqt approved these changes

@bjornfor bjornfor bjornfor approved these changes

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paparodeo @bjornfor @winterqt