tangara-companion: init at 0.4.3 #365308
Open
tangara-companion: init at 0.4.3 #365308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
benpye
force-pushed
the
pkg/tangara-companion/0.4.1
branch
from
8d68cc6 to
0a793b7
Compare
benpye
changed the title
ofborg
bot
added
8.has: package (new)
steeleduncan
suggested changes
Dec 15, 2024
benpye
force-pushed
the
pkg/tangara-companion/0.4.1
branch
from
0a793b7 to
4bda7a6
Compare
benpye
changed the title
|
Thanks for the review @steeleduncan - I think both issues should now be addressed. |
|
qbit
approved these changes
Dec 16, 2024
|
Builds and runs as expected! Would it make sense to also include the command line tool ( |
wegank
added
the
12.approvals: 1
|
I think it would make sense to package the cli as well - but couldn't convince myself if it should be part of the same package or a separate package as it has a much smaller list of dependencies. |
|
Ya.. probably a separate package makes the most sense. |
13 tasks
stevestreza
approved these changes
Dec 21, 2024
wegank
added
12.approvals: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tangara Companion is a companion application for the open source Tangara portable music player.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.