-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tangara-cli: init at 0.4.3 #367227
tangara-cli: init at 0.4.3 #367227
Conversation
2164e08
to
710f798
Compare
|
Shame it needs all the deps to build. |
Yeah, I'm not sure if that's a byproduct of how the project is constructed or if the command I'm using is building more than just the executable. |
Thanks for doing this @stevestreza! I don't mind either way about being added as a maintainer - though I guess it makes approving version updates easier. |
710f798
to
2f50751
Compare
tangara-cli is a command-line tool for flashing firmware for a Tangara music player.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Additional info/questions
dialout
group. Based on grepping around the nixpkgs repo, my hunch is that the solution for this is "this is the user's problem, not the responsibility of the package", but if there's a way to communicate that (via comment in the package or some other thing) or some other precedent for this, I can include that.Add a 👍 reaction to pull requests you find important.