Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tangara-cli: init at 0.4.3 #367227

Merged
merged 2 commits into from
Jan 3, 2025
Merged

tangara-cli: init at 0.4.3 #367227

merged 2 commits into from
Jan 3, 2025

Conversation

stevestreza
Copy link
Contributor

@stevestreza stevestreza commented Dec 21, 2024

tangara-cli is a command-line tool for flashing firmware for a Tangara music player.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Additional info/questions

  • This is my first new package, please do not hesitate to offer feedback if I have made any mistakes or if things could be done better
  • PR is based on the work done in tangara-companion: init at 0.4.3 #365308, so any changes done here should probably reflect there, and vice-versa
  • Based on comments on that PR, this was made into a separate package, but if they are better suited to be packaged together, that's totally fine
  • This package requires access to the serial port to flash firmware, which I believe is done by adding the user to the dialout group. Based on grepping around the nixpkgs repo, my hunch is that the solution for this is "this is the user's problem, not the responsibility of the package", but if there's a way to communicate that (via comment in the package or some other thing) or some other precedent for this, I can include that.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 21, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 21, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 22, 2024
@qbit
Copy link
Contributor

qbit commented Dec 23, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367227


x86_64-linux

✅ 1 package built:
  • tangara-cli

@qbit
Copy link
Contributor

qbit commented Dec 23, 2024

Shame it needs all the deps to build.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 23, 2024
@stevestreza
Copy link
Contributor Author

Shame it needs all the deps to build.

Yeah, I'm not sure if that's a byproduct of how the project is constructed or if the command I'm using is building more than just the executable.

pkgs/by-name/ta/tangara-cli/package.nix Outdated Show resolved Hide resolved
@benpye
Copy link
Contributor

benpye commented Dec 24, 2024

Thanks for doing this @stevestreza! I don't mind either way about being added as a maintainer - though I guess it makes approving version updates easier.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 26, 2024
@misuzu misuzu merged commit a278711 into NixOS:master Jan 3, 2025
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants