Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.flax: disable failing tests on darwin #372122

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

GaetanLepage
Copy link
Contributor

Things done

Failing on darwin with:

>     return tree_util.tree_map(f, tree, *rest, is_leaf=is_leaf)
E     SystemError: nanobind::detail::nb_func_error_except(): exception could not be translated!

cc @ndl

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 8, 2025
@github-actions github-actions bot added 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 8, 2025
@nix-owners nix-owners bot requested review from ndl and fabaff January 8, 2025 12:59
@GaetanLepage GaetanLepage requested a review from NickCao January 9, 2025 16:15
@NickCao
Copy link
Member

NickCao commented Jan 9, 2025

Do we know why it fails?

@GaetanLepage
Copy link
Contributor Author

Do we know why it fails?

Not really. A very similar issue has been happening to equinox: #372132.

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372122


aarch64-darwin

⏩ 6 packages marked as broken and skipped:
  • python312Packages.dalle-mini
  • python312Packages.dalle-mini.dist
  • python312Packages.elegy
  • python312Packages.elegy.dist
  • python312Packages.treex
  • python312Packages.treex.dist
❌ 4 packages failed to build:
  • python312Packages.bambi
  • python312Packages.bambi.dist
  • python312Packages.flowmc
  • python312Packages.flowmc.dist
✅ 8 packages built:
  • python312Packages.evosax
  • python312Packages.evosax.dist
  • python312Packages.flax
  • python312Packages.flax.dist
  • python312Packages.numpyro
  • python312Packages.numpyro.dist
  • python312Packages.vqgan-jax
  • python312Packages.vqgan-jax.dist

@NickCao NickCao merged commit efa54c1 into NixOS:master Jan 11, 2025
22 checks passed
@GaetanLepage GaetanLepage deleted the flax-darwin branch January 11, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants