Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.equinox: skip failing test on darwin #372132

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

GaetanLepage
Copy link
Contributor

Things done

Fails on darwin with

>     all_leaves = [leaves] + [treedef.flatten_up_to(r) for r in rest]
E     SystemError: nanobind::detail::nb_func_error_except(): exception could not be translated!

Similar to #372122

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NickCao
Copy link
Member

NickCao commented Jan 9, 2025

The only reference google can find is: jax-ml/jax#21783, maybe updating the darwin sdk we build nanobind against could help?

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372132


x86_64-linux

❌ 6 packages failed to build:
  • python313Packages.equinox
  • python313Packages.equinox.dist
  • python313Packages.lineax
  • python313Packages.lineax.dist
  • python313Packages.optimistix
  • python313Packages.optimistix.dist
✅ 8 packages built:
  • python312Packages.equinox
  • python312Packages.equinox.dist
  • python312Packages.flowmc
  • python312Packages.flowmc.dist
  • python312Packages.lineax
  • python312Packages.lineax.dist
  • python312Packages.optimistix
  • python312Packages.optimistix.dist

aarch64-linux

❌ 6 packages failed to build:
  • python313Packages.equinox
  • python313Packages.equinox.dist
  • python313Packages.lineax
  • python313Packages.lineax.dist
  • python313Packages.optimistix
  • python313Packages.optimistix.dist
✅ 8 packages built:
  • python312Packages.equinox
  • python312Packages.equinox.dist
  • python312Packages.flowmc
  • python312Packages.flowmc.dist
  • python312Packages.lineax
  • python312Packages.lineax.dist
  • python312Packages.optimistix
  • python312Packages.optimistix.dist

aarch64-darwin

❌ 8 packages failed to build:
  • python312Packages.flowmc
  • python312Packages.flowmc.dist
  • python313Packages.equinox
  • python313Packages.equinox.dist
  • python313Packages.lineax
  • python313Packages.lineax.dist
  • python313Packages.optimistix
  • python313Packages.optimistix.dist
✅ 6 packages built:
  • python312Packages.equinox
  • python312Packages.equinox.dist
  • python312Packages.lineax
  • python312Packages.lineax.dist
  • python312Packages.optimistix
  • python312Packages.optimistix.dist

@GaetanLepage
Copy link
Contributor Author

The only reference google can find is: jax-ml/jax#21783, maybe updating the darwin sdk we build nanobind against could help?

Indeed, this might be the case. @phiadaarr do you have any idea ?

@GaetanLepage
Copy link
Contributor Author

I think that we should merge this. It is a net-plus as of the current situation and I lack time to investigate the issue much more :/

@NickCao NickCao merged commit 55077dd into NixOS:master Jan 11, 2025
25 of 28 checks passed
@GaetanLepage GaetanLepage deleted the equinox branch January 11, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants