Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release 24.11] pnpm_10: init at 10.0.0 #374000

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Jan 15, 2025

Partial backport of #371832, excluding the bump of the default pnpm version to pnpm_10 and therefore the release notes.

WIP: currently testing this PR on GitHub as the new eval is much faster and simpler Done

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gepbird gepbird force-pushed the backport-pnpm-10.0.0 branch 6 times, most recently from b38437e to 71c50b2 Compare January 15, 2025 10:12
(cherry picked from commit 1187945)
@gepbird gepbird force-pushed the backport-pnpm-10.0.0 branch from afc7426 to a7215fe Compare January 15, 2025 15:15
@gepbird
Copy link
Contributor Author

gepbird commented Jan 15, 2025

No unrelated rebuilds

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374000


x86_64-linux

✅ 1 package built:
  • pnpm_10

@gepbird gepbird marked this pull request as ready for review January 15, 2025 16:36
@gepbird gepbird requested a review from Scrumplex January 15, 2025 16:37
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374000


aarch64-darwin

✅ 1 package built:
  • pnpm_10

x86_64-darwin

✅ 1 package built:
  • pnpm_10

x86_64-linux

✅ 1 package built:
  • pnpm_10

@wolfgangwalther wolfgangwalther merged commit 85d2f87 into NixOS:release-24.11 Jan 16, 2025
52 of 55 checks passed
@gepbird gepbird deleted the backport-pnpm-10.0.0 branch January 16, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants