prevent stopping when get STATUS_PENDING from server #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-f
requested changes
Jul 16, 2018
|
The code you refers to is in |
julien-f
reviewed
Jul 16, 2018
| @@ -78,7 +78,7 @@ module.exports = function writeFile(filename, data, options, cb) { | |||
| function callback() { | |||
| return function(err) { | |||
| if (stop) return; | |||
| if (err) { | |||
| if (err && err.code !== 'STATUS_PENDING') { | |||
There was a problem hiding this comment.
I don't understand this change, what does this error mean and what should we do?
Should we resend this packet?
If not, how can we wait for this packet to be written?
There was a problem hiding this comment.
AFAICT, this error only happens in case of async requests/responses which are not currently used in this library.
There was a problem hiding this comment.
but smb2Client.createWriteStream is asynchronous, and I got this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to https://github.com/tracker1/node-smb2/blob/master/lib/api/createWriteStream.js#L82 I needed to be sure that STATUS_PENDING response won't cancel uploading file.