Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent stopping when get STATUS_PENDING from server #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

prevent stopping when get STATUS_PENDING from server #33

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c86e2ab
prevent stopping when get STATUS_PENDING from server
Jul 12, 2018
066649d
changed ensureDir from src to api
Aug 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/api/writeFile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ module.exports = function writeFile(filename, data, options, cb) {
function callback() {
return function(err) {
if (stop) return;
if (err) {
if (err && err.code !== 'STATUS_PENDING') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change, what does this error mean and what should we do?

Should we resend this packet?

If not, how can we wait for this packet to be written?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, this error only happens in case of async requests/responses which are not currently used in this library.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but smb2Client.createWriteStream is asynchronous, and I got this error.

cb && cb(err);
stop = true;
} else {
Expand Down
Loading