[16.0][MIG] base_phone: Migration to 16.0 #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailangvn2023
commented
May 16, 2023
hailangvn2023
commented
- This is to replace [16.0][MIG] base_phone: Migration to 16.0 #296.
base_phone/tests/test_base_phone.py
Outdated
Comment on lines
57
to
58
| partner1._onchange_phone_validation() | ||
| partner1._onchange_mobile_validation() |
There was a problem hiding this comment.
Ca we move to Form to avoid having to call onchanges explicitely? 🙏
base_phone/tests/test_base_phone.py
Outdated
Comment on lines
77
to
78
| partner2._onchange_phone_validation() | ||
| partner2._onchange_mobile_validation() |
Good day @grindtildeath, thanks for your review. The test and the code have been improved. |
This was referenced Jul 20, 2023
|
Hey @OCA/connector-telephony-maintainers could you please have a look at this and merge if possible? |
|
Hey @hailangvn2023 could you please rebase the branch? |
|
/ocabot rebase |
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: connector-telephony-12.0/connector-telephony-12.0-base_phone Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-12-0/connector-telephony-12-0-base_phone/ [UPD] Update base_phone.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: connector-telephony-12.0/connector-telephony-12.0-base_phone Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-12-0/connector-telephony-12-0-base_phone/ [UPD] Update base_phone.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: connector-telephony-12.0/connector-telephony-12.0-base_phone Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-12-0/connector-telephony-12-0-base_phone/ [UPD] Update base_phone.pot Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate. Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate. [UPD] Update base_phone.pot [UPD] Update base_phone.pot [UPD] Update base_phone.pot OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex [UPD] pin flake8 version [ci skip] pre-commit update [ci skip] [UPD] .travis.yml: Use verbose colored pre-commit [skip ci]
…reformatting) from the asterisk_click2dial module to a new base_phone module.
…n phone numbers).
…rmat='xxx' arguments.
- move more asterisk-independant code to base_phone module and create new asterisk-independant modules - rename module asterisk_popup to base_phone_popup - add ability to get callerid names not only from partners, but also from leads, employees, applicants, etc... - same for auto pop-up : not only for partners, but also for leads, employees, etc...
…use it avoids the double inherit of views with phone fields (4 view XML files are removed in asterisk_click2dial* modules thanks to this !) The "Open Calling Partner" feature is now located in the top right menu, next to the Preferences (instead of the Sales menu) A click on tel: and fax: links doesn't open a new tab any more Update description and copyrights of asterisk_click2dial_crm
Convert regular string to translatable string
…letely new behavior As a consequence, the modules asterisk_click2dial_event and asterisk_click2dial_crm_claim have been dropped New wizard "Number not found" (inspired by the old "Open Calling Partner" with many enhancements), which is called by base_phone_popup and Open Caller Formatting of number for click2dial is now handled by the phonenumbers lib: as a consequence, 3 fields have been dropped from asterisk.server (national_prefix, international_prefix, country_prefix) New option 'dial_button_invisible' in the phone widget New sample script asterisk_click2dial/scripts/openerp_popup_timeout.sh Update translations and some module descriptions All the modules are now PEP8 compliant
…%' myself Add logger.error in the function used by the inherit of write/create, for easier debugging when it is called by a webservice Add . in PATH in my sample shell scripts Code cleanup (thank you flake8 !)
…he module Update module description
Currently translated at 100.0% (54 of 54 strings) Translation: connector-telephony-12.0/connector-telephony-12.0-base_phone Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-12-0/connector-telephony-12-0-base_phone/es/
Move tests from base_phone to crm_phone (to benefit from crm_phone_validation) Don't use a demo partner in test (this partner was removed in later versions) Continue to remove dependancy on demo data in tests Forward port of base_phone_popup from v10 to v12 (use web_notify)
Cf my comment for the solution to be compatible with crm_phone_validation without depending on it.
Currently translated at 50.0% (27 of 54 strings) Translation: connector-telephony-12.0/connector-telephony-12.0-base_phone Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-12-0/connector-telephony-12-0-base_phone/pt_BR/
Migrate README to new subdir format Large code clean-up Remove dead lines self.env.user.company_id => self.env.company
Currently translated at 89.2% (50 of 56 strings) Translation: connector-telephony-14.0/connector-telephony-14.0-base_phone Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-base_phone/es_AR/
Currently translated at 100.0% (56 of 56 strings) Translation: connector-telephony-14.0/connector-telephony-14.0-base_phone Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-base_phone/fr/
|
Congratulations, PR rebased to 16.0. |
OCA-git-bot
force-pushed
the
16.0-mig-base_phone
branch
from
fbc2406 to
5babcc8
Compare
|
pop @hailangvn , any chance to fix precommit ? |
|
Superseded by #314 |
@flotho could you please take a look at #314 ? This PR already rebase and fix pre-commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.