Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] l10n_es_aeat_sii_oca: Add Enable SII to journals to enable compatibilities (hr_expense for example) #3824

Merged

Conversation

victoralmau
Copy link
Member

Add Enable SII to journals to enable compatibilities (hr_expense for example)

Steps to reproduce:

  • Install hr_expense
  • Create a purchase type journal named Expenses and uncheck the Enable SII field.
  • Go to Expense > Configuration > Settings and define in Employee Expense Journal the Expenses journal previously created
  • Create an expense and an expense sheet
  • Click on the Submit to manager button
  • Click on the Approve button
  • Click on the Post journal entries button
  • The journal entry will be created correctly without any error

Please @pedrobaeza can you review it?

@Tecnativa TT51825

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 25, 2024
@victoralmau victoralmau force-pushed the 16.0-imp-l10n_es_aeat_sii_oca-TT51825 branch from 33cd7a1 to d594b47 Compare November 26, 2024 07:23
…atibilities (hr_expense for example)

Steps to reproduce:
- Install hr_expense
- Create a purchase type journal named Expenses and uncheck the Enable SII field.
- Go to Expense > Configuration > Settings and define in Employee Expense Journal the
Expenses journal previously created
- Create an expense and an expense sheet
- Click on the Submit to manager button
- Click on the Approve button
- Click on the Post journal entries button
- The journal entry will be created correctly without any error

TT51825
@victoralmau victoralmau force-pushed the 16.0-imp-l10n_es_aeat_sii_oca-TT51825 branch from d594b47 to c5343ac Compare November 26, 2024 07:38
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genial, gracias. Se puede llevar a 15 y 17.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3824-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d234085 into OCA:16.0 Nov 26, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8808544. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants