Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name to package #14

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Name to package #14

merged 6 commits into from
Apr 22, 2024

Conversation

kba
Copy link
Member

@kba kba commented Apr 15, 2024

fix #10

Copy link
Contributor

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This fixes issue #10.

@stweil
Copy link
Contributor

stweil commented Apr 15, 2024

See result of complete test matrix where now all checks pass.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@kba
Copy link
Member Author

kba commented Apr 16, 2024

See result of complete test matrix where now all checks pass.

I still see an issue with 3.9. I think it's best to rely on importlib_resources package for <= 3.9 (instead of just <= 3.8) because there the behavior is correct. Will prepare a PR in core for that.

@kba kba merged commit 7267d1e into main Apr 22, 2024
4 checks passed
@stweil
Copy link
Contributor

stweil commented Apr 22, 2024

Thanks, @kba, for your work. It's nice to have green CI tests now.

@bertsky
Copy link
Contributor

bertsky commented May 23, 2024

I still see an issue with 3.9. I think it's best to rely on importlib_resources package for <= 3.9 (instead of just <= 3.8) because there the behavior is correct.

Matplotlib would agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: 'ocrd_froc.processor' is not a package
3 participants