fix:update fpga dfl ioctl changes and bug fixes #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Remove numa node from dfl ioctl - Fix bugs -Add HE-CACHE csr function to print csr. Signed-off-by: anandaravuri <[email protected]>
Pull Request Test Coverage Report for Build 6499770113
💛 - Coveralls |
tswhison
reviewed
Oct 6, 2023
Comment on lines
+245
to
+246
| he_ctl_.Start = 0; | ||
| host_exe_->write64(HE_CTL, he_ctl_.value); |
There was a problem hiding this comment.
This seems odd. I think that the hardware would want to clear the bit once the test was started. That way, software could check whether the hardware has started. May want to raise this to the hw team.
- add command line input --bias to support CXL-IP modes - add command line input --device to support multiple he-cache instances Signed-off-by: anandaravuri <[email protected]>
Signed-off-by: anandaravuri <[email protected]>
tswhison
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Remove numa node from dfl ioctl
-Add HE-CACHE csr function to print csr.