Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud 31 compatibility and some code cleanup #1056

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

juliusknorr
Copy link
Contributor

@juliusknorr juliusknorr commented Jan 20, 2025

Follow up to #1041 as there were quite some parts missing which makes the app not work properly with upcomping Nextcloud 31

  • getLogger is removed since chore!: Remove ILogger and its friends  nextcloud/server#47978, replacing with the public logger method that does the same thing
  • Move away from \OC::$server as it is internal API, ideally the app should use dependency injection more, but for quick migration switching to \OCP\Server::get works
  • Remove usage of logException which is no longer available, also no need to pass app to each log statement as when getting the logger in the app scope we already have that set
  • Cleanup service registration in Application.php as these days services will be auto wired based on the class name
  • Move AppConfig over to use constructor property promotion as a new feature of PHP 8.0 that allows less lines of code

@juliusknorr juliusknorr changed the base branch from master to develop January 20, 2025 15:48
@LinneyS LinneyS requested a review from rivexe January 20, 2025 19:20
@juliusknorr juliusknorr changed the title chore/private apis Nextcloud 31 compatibility and some code cleanup Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant