chore: Move to constructor property promotion

Signed-off-by: Julius Knorr <jus@bitgrid.net>

lib/AppConfig.php

@@ -36,35 +36,14 @@
 use OCP\ICacheFactory;
 use OCP\IConfig;
 use Psr\Log\LoggerInterface;
+use OCA\Onlyoffice\AppInfo\Application;
 
 /**
  * Application configutarion
  *
  * @package OCA\Onlyoffice
  */
 class AppConfig {
-
-    /**
-     * Application name
-     *
-     * @var string
-     */
-    private $appName;
-
-    /**
-     * Config service
-     *
-     * @var IConfig
-     */
-    private $config;
-
-    /**
-     * Logger
-     *
-     * @var LoggerInterface
-     */
-    private $logger;
-
     /**
      * The config key for the demo server
      *
@@ -361,22 +340,16 @@ class AppConfig {
 
     /**
      * The config key for store cache
-     *
-     * @var ICache
      */
-    private $cache;
-
-    /**
-     * @param string $AppName - application name
-     */
-    public function __construct($AppName) {
-
-        $this->appName = $AppName;
+    private ICache $cache;
 
-        $this->config = \OC::$server->getConfig();
-        $this->logger = \OCP\Server::get(LoggerInterface::class);
-        $cacheFactory = \OCP\Server::get(ICacheFactory::class);
-        $this->cache = $cacheFactory->createLocal($this->appName);
+    public function __construct(
+        private string $appName,
+        private IConfig $config,
+        private LoggerInterface $logger,
+        ICacheFactory $cacheFactory,
+    ) {
+        $this->cache = $cacheFactory->createLocal(Application::APP_ID);
     }
 
     /**