Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update isSelfAsserted method in funding and fix NPE in peer review #6899

Merged
merged 2 commits into from
Oct 3, 2023

Merge branch 'main' into 8716-source-sorting-option

3345630
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix: Update isSelfAsserted method in funding and fix NPE in peer review #6899

Merge branch 'main' into 8716-source-sorting-option
3345630
Select commit
Loading
Failed to load commit list.
GitHub Actions / orcid-api-common Unit Tests succeeded Oct 3, 2023 in 1s

orcid-api-common Unit Tests ✅

Tests passed successfully

Report Passed Failed Skipped Time
TEST-org.orcid.api.common.analytics.AnalyticsProcessTest.xml 18✅ 301ms
TEST-org.orcid.api.common.analytics.APIEndpointParserTest.xml 9✅ 745ms
TEST-org.orcid.api.common.analytics.client.google.UniversalAnalyticsClientTest.xml 2✅ 516ms
TEST-org.orcid.api.common.filter.ApiVersionCheckFilterTest.xml 8✅ 95ms
TEST-org.orcid.api.common.filter.TokenTargetFilterTest.xml 5✅ 241ms
TEST-org.orcid.api.common.oauth.OrcidClientCredentialEndPointDelegatorTest.xml 7✅ 33s
TEST-org.orcid.api.common.util.ActivityUtilsTest.xml 15✅ 20ms
TEST-org.orcid.api.common.util.v3.ActivityUtilsTest.xml 20✅ 2ms
TEST-org.orcid.api.common.writer.citeproc.WorkToCiteprocTranslatorTest.xml 4✅ 395ms
TEST-org.orcid.api.common.writer.rdf.RDFWriterTest.xml 5✅ 1s
TEST-org.orcid.api.common.writer.SchemaOrgDocumentTest.xml 1✅ 64ms

✅ TEST-org.orcid.api.common.analytics.AnalyticsProcessTest.xml

18 tests were completed in 301ms with 18 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.analytics.AnalyticsProcessTest 18✅ 301ms

✅ org.orcid.api.common.analytics.AnalyticsProcessTest

✅ testAnalyticsProcessForGetRequestWithUnknownAcceptHeader
✅ testAnalyticsProcessForAnonymous
✅ testAnalyticsProcessForGetRequestWithXmlAcceptHeader
✅ testAnalyticsProcessForGetRequestWithJsonAcceptHeader
✅ testAnalyticsProcessForGetRequestWithJsonContentTypeHeader
✅ testAnalyticsProcessForGetRequestWithXmlContentTypeHeader
✅ testAnalyticsProcessForGetRequestWithRdfXmlContentTypeHeader
✅ testAnalyticsProcessForIPv6
✅ testAnalyticsProcessForMemberClient
✅ testAnalyticsProcessForPublicClientWithAmpersand
✅ testAnalyticsProcessForGetRequestWithJsonLdContentTypeHeader
✅ testAnalyticsProcessForPublicClient
✅ testAnalyticsProcessForPostRequestWithUnknownContentTypeHeader
✅ testAnalyticsProcessForPostRequestWithXmlContentTypeHeader
✅ testAnalyticsProcessWithNoContentType
✅ testAnalyticsProcessForPostRequestWithJsonContentTypeHeader
✅ testAnalyticsProcessForNoSpecifiedCategory
✅ testSchemeCorrection

✅ TEST-org.orcid.api.common.analytics.APIEndpointParserTest.xml

9 tests were completed in 745ms with 9 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.analytics.APIEndpointParserTest 9✅ 745ms

✅ org.orcid.api.common.analytics.APIEndpointParserTest

✅ testAPIEndpointParserWithApiVersionWithoutOrcid
✅ testAPIEndpointParserNoCategoryV1
✅ testAPIEndpointParserNoCategoryV2
✅ testAPIEndpointParserNoCategoryV3
✅ testAPIEndpointParserNoCategoryOrVersion
✅ testAPIEndpointParserWithApiVersionAndOrcid
✅ testAPIEndpointParserWithoutApiVersionWithOrcid
✅ testInvalidEventCategory
✅ testAPIEndpointParserWithoutApiVersionOrOrcid

✅ TEST-org.orcid.api.common.analytics.client.google.UniversalAnalyticsClientTest.xml

2 tests were completed in 516ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.analytics.client.google.UniversalAnalyticsClientTest 2✅ 516ms

✅ org.orcid.api.common.analytics.client.google.UniversalAnalyticsClientTest

✅ testSendAnalyticsDataNoTrackingCode
✅ testSendAnalyticsData

✅ TEST-org.orcid.api.common.filter.ApiVersionCheckFilterTest.xml

8 tests were completed in 95ms with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.filter.ApiVersionCheckFilterTest 8✅ 95ms

✅ org.orcid.api.common.filter.ApiVersionCheckFilterTest

✅ apiV2SchemeTest
✅ api2_0VersionTest
✅ webhooksShouldWorkWithoutVersionTest
✅ apiOauthTokenTest
✅ apiV2HeaderTest
✅ apiV2BlockHttpTest
✅ apiDefaultVersionTest
✅ invalidWebhooksShouldNotWork

✅ TEST-org.orcid.api.common.filter.TokenTargetFilterTest.xml

5 tests were completed in 241ms with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.filter.TokenTargetFilterTest 5✅ 241ms

✅ org.orcid.api.common.filter.TokenTargetFilterTest

✅ readPublicTokenTest
✅ tokenUsedOnTheRightUserTest
✅ tokenUsedOnTheWrongUser20ApiTest
✅ filterInvokedOnNoOrcidEndpointTest
✅ tokenUsedOnTheWrongUser12ApiTest

✅ TEST-org.orcid.api.common.oauth.OrcidClientCredentialEndPointDelegatorTest.xml

7 tests were completed in 33s with 7 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.oauth.OrcidClientCredentialEndPointDelegatorTest 7✅ 33s

✅ org.orcid.api.common.oauth.OrcidClientCredentialEndPointDelegatorTest

✅ generateRefreshTokenThatExpireAfterParentTokenTest
✅ generateClientCredentialsAccessTokenWithInvalidTokenTest
✅ generateAccessTokenTest
✅ obtainOauth2TokenSkipCacheTest
✅ generateRefreshTokenTest
✅ generateClientCredentialsAccessTokenTest
✅ obtainOauth2TokenSetCacheTest

✅ TEST-org.orcid.api.common.util.ActivityUtilsTest.xml

15 tests were completed in 20ms with 15 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.util.ActivityUtilsTest 15✅ 20ms

✅ org.orcid.api.common.util.ActivityUtilsTest

✅ cleanWorkTest
✅ setPathToFundingsTest
✅ setPathToActivitiesSummaryTest
✅ setPathToWorksTest
✅ setPathToPeerReviewsTest
✅ setPathToActivityTest
✅ cleanBulkWorkTest
✅ cleanFundingTest
✅ cleanEmptyActivitiesSummaryTest
✅ setPathToEmploymentsTest
✅ cleanWorksTest
✅ cleanBulkElementTest
✅ cleanOrganizationTest
✅ cleanWorkSummaryTest
✅ setPathToEducationsTest

✅ TEST-org.orcid.api.common.util.v3.ActivityUtilsTest.xml

20 tests were completed in 2ms with 20 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.util.v3.ActivityUtilsTest 20✅ 2ms

✅ org.orcid.api.common.util.v3.ActivityUtilsTest

✅ cleanWorkTest
✅ setPathToFundingsTest
✅ setPathToInvitedPositionsTest
✅ setPathToActivitiesSummaryTest
✅ setPathToServicesTest
✅ setPathToDistinctionsTest
✅ setPathToWorksTest
✅ setPathToPeerReviewsTest
✅ setPathToActivityTest
✅ setPathToMembershipsTest
✅ setPathToQualificationTest
✅ cleanBulkWorkTest
✅ cleanFundingTest
✅ cleanEmptyActivitiesSummaryTest
✅ setPathToEmploymentsTest
✅ cleanWorksTest
✅ cleanBulkElementTest
✅ cleanOrganizationTest
✅ cleanWorkSummaryTest
✅ setPathToEducationsTest

✅ TEST-org.orcid.api.common.writer.citeproc.WorkToCiteprocTranslatorTest.xml

4 tests were completed in 395ms with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.writer.citeproc.WorkToCiteprocTranslatorTest 4✅ 395ms

✅ org.orcid.api.common.writer.citeproc.WorkToCiteprocTranslatorTest

✅ testUnicode
✅ testBibtexWorkTranslationHyperAuthorNoAbrev
✅ testBibtexWorkTranslationHyperAuthor
✅ testBibtexWorkTranslationHyperAuthorLiteralAndMissingDOI

✅ TEST-org.orcid.api.common.writer.rdf.RDFWriterTest.xml

5 tests were completed in 1s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.writer.rdf.RDFWriterTest 5✅ 1s

✅ org.orcid.api.common.writer.rdf.RDFWriterTest

✅ writeTurte
✅ writeNtriples
✅ missingCreditName
✅ writeJsonLD
✅ writeRdfXML

✅ TEST-org.orcid.api.common.writer.SchemaOrgDocumentTest.xml

1 tests were completed in 64ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.writer.SchemaOrgDocumentTest 1✅ 64ms

✅ org.orcid.api.common.writer.SchemaOrgDocumentTest

✅ testSerialisation