Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update isSelfAsserted method in funding and fix NPE in peer review #6899

Merged
merged 2 commits into from
Oct 3, 2023

Merge branch 'main' into 8716-source-sorting-option

3345630
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix: Update isSelfAsserted method in funding and fix NPE in peer review #6899

Merge branch 'main' into 8716-source-sorting-option
3345630
Select commit
Loading
Failed to load commit list.
GitHub Actions / orcid-pub-web Unit Tests succeeded Oct 3, 2023 in 1s

orcid-pub-web Unit Tests ✅

Tests passed successfully

Report Passed Failed Skipped Time
TEST-org.orcid.api.identifiers.IdentifierApiServiceDelegatorTest.xml 2✅ 35s
TEST-org.orcid.api.publicV2.server.PublicV2ApiServiceDelegatorTest.xml 79✅ 15s
TEST-org.orcid.api.publicV2.server.PublicV2ApiServiceVersionedDelegatorTest.xml 111✅ 5s
TEST-org.orcid.api.publicV2.server.security.PublicAPISecurityManagerV2Test.xml 19✅ 16ms
TEST-org.orcid.api.publicV3.server.PublicV3ApiServiceDelegatorTest.xml 116✅ 5s
TEST-org.orcid.api.publicV3.server.security.PublicAPISecurityManagerV3Test.xml 24✅ 40ms

✅ TEST-org.orcid.api.identifiers.IdentifierApiServiceDelegatorTest.xml

2 tests were completed in 35s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.identifiers.IdentifierApiServiceDelegatorTest 2✅ 35s

✅ org.orcid.api.identifiers.IdentifierApiServiceDelegatorTest

✅ testviewIdentifierTypes
✅ testviewIdentifierTypesWithLocale

✅ TEST-org.orcid.api.publicV2.server.PublicV2ApiServiceDelegatorTest.xml

79 tests were completed in 15s with 79 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.publicV2.server.PublicV2ApiServiceDelegatorTest 79✅ 15s

✅ org.orcid.api.publicV2.server.PublicV2ApiServiceDelegatorTest

✅ testViewExternalIdentifier
✅ testViewAddresses
✅ testViewExternalIdentifiers
✅ testGetPrivateBiographyUsingToken
✅ testGetPrivateEducationUsingToken
✅ testViewAddress
✅ testViewBulkWorks
✅ testViewResearcherUrls
✅ testViewKeyword
✅ testGetPublicAddressUsingToken
✅ testGetPublicEducationsUsingToken
✅ testGetPrivateAddressUsingToken
✅ testViewFunding
✅ testGetLimitedEmploymentUsingToken
✅ testGetLimitedWorkUsingToken
✅ testViewWorks
✅ testGetLimitedResearcherUrlUsingToken
✅ testGetPublicEmploymentUsingToken
✅ testSearchByQuery
✅ testGetPublicResearcherUrlUsingToken
✅ testFindPerson
✅ testSchemaOrgMBWriterV2
✅ testViewPeerReview
✅ testFindRecord
✅ testViewOtherName
✅ testGetPublicFundings
✅ testGetPrivateEmploymentUsingToken
✅ testGetPublicOtherNameUsingToken
✅ testGetPublicWorksUsingToken
✅ testViewResearcherUrl
✅ testGetPublicPeerReviewsUsingToken
✅ testGetPublicExternalIdentifierUsingToken
✅ testGetPublicFundingUsingToken
✅ testGetLimitedAddressUsingToken
✅ testGetPrivateResearcherUrlUsingToken
✅ testViewPeerReviews
✅ testGetPrivateFundingUsingToken
✅ testSearchByQueryIllegalStart
✅ testGetPublicKeywordUsingToken
✅ testGetLimitedOtherNameUsingToken
✅ testGetPrivateKeywordUsingToken
✅ testFindPersonalDetails
✅ testViewClientNonExistent
✅ testGetLimitedExternalIdentifierUsingToken
✅ testGetPublicPeerReviews
✅ testGetPublicWorkUsingToken
✅ testGetPublicBiographyUsingToken
✅ testValidatePersonUsingToken
✅ testFindActivityDetails
✅ testGetPublicEducations
✅ testGetPublicEducationUsingToken
✅ testViewEducation
✅ testGetPublicEmploymentsUsingToken
✅ testGetPrivateOtherNameUsingToken
✅ testViewEducations
✅ testValidateActivitiesUsingToken
✅ testValidateRecordUsingToken
✅ testGetLimitedPeerReviewUsingToken
✅ testSearchByQueryLegalStart
✅ testViewClient
✅ testViewKeywords
✅ testViewEmployments
✅ testGetLimitedFundingUsingToken
✅ testViewEmails
✅ testGetPublicWorks
✅ testViewOtherNames
✅ testGetPublicPeerReviewUsingToken
✅ testGetLimitedKeywordUsingToken
✅ testGetLimitedBiographyUsingToken
✅ testViewEmployment
✅ testGetPrivatePeerReviewUsingToken
✅ testGetLimitedEducationUsingToken
✅ testViewWork
✅ testGetPublicEmployments
✅ testGetPrivateWorkUsingToken
✅ testGetPublicFundingsUsingToken
✅ testSearchByQueryTooManyRows
✅ testGetPrivateExternalIdentifierUsingToken
✅ testViewFundings

✅ TEST-org.orcid.api.publicV2.server.PublicV2ApiServiceVersionedDelegatorTest.xml

111 tests were completed in 5s with 111 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.publicV2.server.PublicV2ApiServiceVersionedDelegatorTest 111✅ 5s

✅ org.orcid.api.publicV2.server.PublicV2ApiServiceVersionedDelegatorTest

✅ test03ViewOtherNames
✅ test01ViewAddresses
✅ test02ViewEducationSummary
✅ test00ViewAddress
✅ test00ViewEmployment
✅ test0103ViewActivities
✅ test03ViewExternalIdentifiers
✅ test01ViewAddress
✅ test00ViewPerson
✅ test02ViewExternalIdentifiers
✅ test00ViewRecord
✅ test03ViewEducationSummary
✅ testViewBulkWorks
✅ test01ViewExternalIdentifiers
✅ test02ViewAddress
✅ test01ViewExternalIdentifier
✅ test03ViewEmployment
✅ test00ViewExternalIdentifiers
✅ test00ViewKeyword
✅ test03ViewAddress
✅ test03ViewOtherName
✅ test01ViewEmploymentSummary
✅ test02ViewResearcherUrl
✅ test00ViewAddresses
✅ test01ViewKeyword
✅ test03ViewPersonalDetails
✅ test02ViewEmails
✅ test02ViewKeyword
✅ test02ViewResearcherUrls
✅ test03ViewEmploymentSummary
✅ test00ViewFunding
✅ test02ViewPeerReview
✅ test03ViewKeyword
✅ test01ViewFunding
✅ test02ViewPerson
✅ test02ViewPersonalDetails
✅ test02ViewRecord
✅ test02ViewFunding
✅ test02ViewOtherName
✅ test03ViewFundingSummary
✅ test03ViewFunding
✅ test01ViewOtherNames
✅ testSearchByQuery
✅ test01ViewPersonalDetails
✅ test01ViewWork
✅ test01ViewOtherName
✅ test01ViewResearcherUrl
✅ test01ViewResearcherUrls
✅ test02ViewExternalIdentifier
✅ test03ViewKeywords
✅ test01ViewEmployment
✅ test01ViewPeerReviewSummary
✅ test00ViewPersonalDetails
✅ test02ViewKeywords
✅ test03ViewPeerReviewSummary
✅ test02ViewFundingSummary
✅ test00ViewOtherName
✅ test00ViewActivities
✅ test00ViewPeerReview
✅ test03ViewWork
✅ test03ViewEducation
✅ test01ViewKeywords
✅ test03ViewWorkSummary
✅ test03ViewPeerReview
✅ test00ViewResearcherUrls
✅ test01ViewEmails
✅ testViewClientNonExistent
✅ test03ViewBiography
✅ test00ViewResearcherUrl
✅ testViewBulkWorksNonExistentUser
✅ test00ViewKeywords
✅ test00ViewEmploymentSummary
✅ test02ViewEducation
✅ test01ViewPerson
✅ test02ViewEmploymentSummary
✅ test02ViewWorkSummary
✅ test01ViewRecord
✅ test02ViewOtherNames
✅ test01ViewFundingSummary
✅ test03ViewExternalIdentifier
✅ test0102ViewActivities
✅ test02ViewBiography
✅ test03ViewEmails
✅ test01ViewEducation
✅ test02ViewEmployment
✅ test00ViewWork
✅ test01ViewWorkSummary
✅ test03ViewAddresses
✅ testViewClient
✅ testViewBiographyWhereBiographyIsNull
✅ test00ViewExternalIdentifier
✅ test03ViewPerson
✅ test03ViewRecord
✅ test01ViewBiography
✅ test01ViewActivities
✅ test01ViewPeerReview
✅ test00ViewFundingSummary
✅ test00ViewEducation
✅ testViewDeactivatedRecordDontThrowError
✅ test00ViewPeerReviewSummary
✅ test00ViewWorkSummary
✅ test03ViewResearcherUrl
✅ test02ViewAddresses
✅ test02ViewWork
✅ test00ViewEducationSummary
✅ test02ViewPeerReviewSummary
✅ test00ViewBiography
✅ test00ViewOtherNames
✅ test03ViewResearcherUrls
✅ test01ViewEducationSummary
✅ test00ViewEmails

✅ TEST-org.orcid.api.publicV2.server.security.PublicAPISecurityManagerV2Test.xml

19 tests were completed in 16ms with 19 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.publicV2.server.security.PublicAPISecurityManagerV2Test 19✅ 16ms

✅ org.orcid.api.publicV2.server.security.PublicAPISecurityManagerV2Test

✅ checkIsPublicBiographyTest
✅ checkIsPublicFilterableTest
✅ filterPeerReviewsTest
✅ filterFundingsTest
✅ filterEmploymentsTest
✅ filterWorksTest
✅ filterExternalIdentifiersTest
✅ checkIsPublicNameTest
✅ filterAddressesTest
✅ checkIsPublicPersonTest
✅ checkIsPublicRecordTest
✅ checkIsPublicVisibilityTypeTest
✅ filterEmailsTest
✅ checkIsPublicPersonalDetailsTest
✅ checkIsPublicActivitiesSummaryTest
✅ filterKeywordsTest
✅ filterResearcherUrlsTest
✅ filterOtherNamesTest
✅ filterEducationsTest

✅ TEST-org.orcid.api.publicV3.server.PublicV3ApiServiceDelegatorTest.xml

116 tests were completed in 5s with 116 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.publicV3.server.PublicV3ApiServiceDelegatorTest 116✅ 5s

✅ org.orcid.api.publicV3.server.PublicV3ApiServiceDelegatorTest

✅ testViewExternalIdentifier
✅ testViewAddresses
✅ testGetPublicMembershipUsingToken
✅ testViewExternalIdentifiers
✅ testGetPrivateBiographyUsingToken
✅ testGetPublicDistinctionUsingToken
✅ testGetPublicMemberships
✅ testGetPrivateMembershipUsingToken
✅ testGetPrivateEducationUsingToken
✅ testViewDistinction
✅ testGetLimitedDistinctionUsingToken
✅ testViewAddress
✅ testViewBulkWorks
✅ testViewDistinctions
✅ testViewResearcherUrls
✅ testViewQualification
✅ testViewKeyword
✅ testGetPublicAddressUsingToken
✅ testExpandedSearchByQueryNoRowsParamSet
✅ testGetPublicInvitedPositionsUsingToken
✅ testGetPublicEducationsUsingToken
✅ testGetPrivateAddressUsingToken
✅ testViewFunding
✅ testGetLimitedEmploymentUsingToken
✅ testGetLimitedWorkUsingToken
✅ testGetPublicServiceUsingToken
✅ testGetPublicQualifications
✅ testViewWorks
✅ testGetLimitedResearcherUrlUsingToken
✅ testGetPrivateServiceUsingToken
✅ testGetPublicEmploymentUsingToken
✅ testSearchByQuery
✅ testGetPublicResearcherUrlUsingToken
✅ testFindPerson
✅ testSchemaOrgMBWriterV3
✅ testViewPeerReview
✅ testFindRecord
✅ testViewOtherName
✅ testGetPublicServices
✅ testGetPublicFundings
✅ testGetPrivateEmploymentUsingToken
✅ testGetPublicOtherNameUsingToken
✅ testGetPublicWorksUsingToken
✅ testViewResearcherUrl
✅ testGetPublicServicesUsingToken
✅ testGetPublicPeerReviewsUsingToken
✅ testGetLimitedInvitedPositionUsingToken
✅ testGetPublicMembershipsUsingToken
✅ testGetPublicExternalIdentifierUsingToken
✅ testGetPublicFundingUsingToken
✅ testGetLimitedAddressUsingToken
✅ testGetPrivateResearcherUrlUsingToken
✅ testViewPeerReviews
✅ testGetPublicQualificationsUsingToken
✅ testGetPrivateFundingUsingToken
✅ testSearchByQueryIllegalStart
✅ testGetPublicKeywordUsingToken
✅ testViewMembership
✅ testGetLimitedOtherNameUsingToken
✅ testGetPrivateKeywordUsingToken
✅ testGetPublicInvitedPositionUsingToken
✅ testFindPersonalDetails
✅ testViewClientNonExistent
✅ testGetLimitedServiceUsingToken
✅ testGetPublicDistinctionsUsingToken
✅ testGetLimitedQualificationUsingToken
✅ testGetLimitedExternalIdentifierUsingToken
✅ testGetPublicPeerReviews
✅ testGetPublicWorkUsingToken
✅ testGetPublicQualificationUsingToken
✅ testGetPublicDistinctions
✅ testGetPublicBiographyUsingToken
✅ testValidatePersonUsingToken
✅ testFindActivityDetails
✅ testGetPublicEducations
✅ testGetPrivateDistinctionUsingToken
✅ testViewInvitedPositions
✅ testGetPublicEducationUsingToken
✅ testViewEducation
✅ testGetPublicEmploymentsUsingToken
✅ testGetPrivateOtherNameUsingToken
✅ testViewEducations
✅ testValidateActivitiesUsingToken
✅ testViewQualifications
✅ testValidateRecordUsingToken
✅ testGetLimitedPeerReviewUsingToken
✅ testSearchByQueryLegalStart
✅ testViewClient
✅ testViewKeywords
✅ testViewEmployments
✅ testGetLimitedFundingUsingToken
✅ testViewEmails
✅ testGetPublicWorks
✅ testViewService
✅ testViewOtherNames
✅ testGetPrivateQualificationUsingToken
✅ testGetPublicPeerReviewUsingToken
✅ testGetLimitedKeywordUsingToken
✅ testGetLimitedBiographyUsingToken
✅ testViewEmployment
✅ testGetPrivateInvitedPositionUsingToken
✅ testGetPrivatePeerReviewUsingToken
✅ testGetLimitedEducationUsingToken
✅ testViewMemberships
✅ testViewInvitedPosition
✅ testViewWork
✅ testGetPublicEmployments
✅ testGetLimitedMembershipUsingToken
✅ testGetPrivateWorkUsingToken
✅ testGetPublicInvitedPositions
✅ testGetPublicFundingsUsingToken
✅ testSearchByQueryTooManyRows
✅ testViewClientSummary
✅ testGetPrivateExternalIdentifierUsingToken
✅ testViewServices
✅ testViewFundings

✅ TEST-org.orcid.api.publicV3.server.security.PublicAPISecurityManagerV3Test.xml

24 tests were completed in 40ms with 24 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.publicV3.server.security.PublicAPISecurityManagerV3Test 24✅ 40ms

✅ org.orcid.api.publicV3.server.security.PublicAPISecurityManagerV3Test

✅ checkIsPublicBiographyTest
✅ checkIsPublicFilterableTest
✅ filterDistinctionsTest
✅ filterPeerReviewsTest
✅ filterMembershipsTest
✅ filterFundingsTest
✅ filterServicesTest
✅ filterEmploymentsTest
✅ filterWorksTest
✅ filterExternalIdentifiersTest
✅ checkIsPublicNameTest
✅ filterAddressesTest
✅ filterInvitedPositionsTest
✅ checkIsPublicPersonTest
✅ checkIsPublicRecordTest
✅ filterQualificationsTest
✅ checkIsPublicVisibilityTypeTest
✅ filterEmailsTest
✅ checkIsPublicPersonalDetailsTest
✅ checkIsPublicActivitiesSummaryTest
✅ filterKeywordsTest
✅ filterResearcherUrlsTest
✅ filterOtherNamesTest
✅ filterEducationsTest