Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extids to peer review notification #7046

Merged
merged 25 commits into from
Jul 1, 2024

Update code so it uses string builder

88aa19c
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Add extids to peer review notification #7046

Update code so it uses string builder
88aa19c
Select commit
Loading
Failed to load commit list.
GitHub Actions / orcid-message-listener Unit Tests succeeded Jul 1, 2024 in 0s

orcid-message-listener Unit Tests ✅

Tests passed successfully

Report Passed Failed Skipped Time
TEST-org.orcid.listener.clients.S3ManagerTest.xml 8✅ 2s
TEST-org.orcid.listener.common.S3MessageProcessorAPIV2Test.xml 36✅ 4s
TEST-org.orcid.listener.common.S3MessageProcessorAPIV3Test.xml 72✅ 551ms
TEST-org.orcid.listener.converter.OrcidRecordToSolrDocumentTest.xml 1✅ 52ms
TEST-org.orcid.listener.persistence.dao.Api20RecordStatusDaoTest.xml 3✅ 165ms
TEST-org.orcid.listener.persistence.dao.Api30RecordStatusDaoTest.xml 3✅ 52ms
TEST-org.orcid.listener.s3.S3MessagingServiceTest.xml 2✅ 5ms

✅ TEST-org.orcid.listener.clients.S3ManagerTest.xml

8 tests were completed in 2s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.listener.clients.S3ManagerTest 8✅ 2s

✅ org.orcid.listener.clients.S3ManagerTest

✅ clearV2ActivitiesByTypeTest
✅ clearV3ActivitiesByTypeTest
✅ updateS3_V3RecordTest
✅ uploadV3ActivityTest
✅ uploadV2OrcidErrorTest
✅ uploadV2ActivityTest
✅ updateS3_V2RecordTest
✅ uploadV3OrcidErrorTest

✅ TEST-org.orcid.listener.common.S3MessageProcessorAPIV2Test.xml

36 tests were completed in 4s with 36 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.listener.common.S3MessageProcessorAPIV2Test 36✅ 4s

✅ org.orcid.listener.common.S3MessageProcessorAPIV2Test

✅ addFundingsTest
✅ addPeerReviewsTest
✅ removePeerReviewsFailTest
✅ removeEducationsTest
✅ activities_EmploymentsFailTest
✅ removeEducationsFailTest
✅ recordSummary_AmazonClientExceptionTest
✅ removeEmploymentsTest
✅ removeFundingsTest
✅ removeAllPeerReviewsTest
✅ removeEmploymentsFailTest
✅ removeWorksTest
✅ addEmploymentsTest
✅ uploadPeerReviewBecauseLastModifiedChangedTest
✅ removeAllFundingsTest
✅ v20RecordDeprecatedExceptionTest
✅ recordStatusMarkAllOkTest
✅ removeAllEmploymentsTest
✅ uploadNothingTest
✅ addEducationsTest
✅ removeAllEducationsTest
✅ v20RecordLockedExceptionTest
✅ removeAllWorksTest
✅ uploadEmploymentsBecauseLastModifiedChangedTest
✅ recordSummary_JAXBExceptionTest
✅ addWorksTest
✅ removeFundingsFailTest
✅ uploadWorksBecauseLastModifiedChangedTest
✅ uploadFundingsBecauseLastModifiedChangedTest
✅ uploadEducationsBecauseLastModifiedChangedTest
✅ activities_FundingsFailTest
✅ activities_WorksFailTest
✅ activities_EducationsFailTest
✅ removeWorksFailTest
✅ removePeerReviewsTest
✅ activities_PeerReviewsFailTest

✅ TEST-org.orcid.listener.common.S3MessageProcessorAPIV3Test.xml

72 tests were completed in 551ms with 72 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.listener.common.S3MessageProcessorAPIV3Test 72✅ 551ms

✅ org.orcid.listener.common.S3MessageProcessorAPIV3Test

✅ removeDistinctionsTest
✅ removeResearchResourcesFailTest
✅ addFundingsTest
✅ addPeerReviewsTest
✅ removeMembershipsFailTest
✅ activities_QualificationsFailTest
✅ addMembershipsTest
✅ removePeerReviewsFailTest
✅ addServicesTest
✅ removeEducationsTest
✅ activities_EmploymentsFailTest
✅ removeEducationsFailTest
✅ uploadServicesBecauseLastModifiedChangedTest
✅ recordSummary_AmazonClientExceptionTest
✅ uploadQualificationsBecauseLastModifiedChangedTest
✅ removeEmploymentsTest
✅ addDistinctionsTest
✅ removeAllQualificationsTest
✅ removeFundingsTest
✅ uploadResearchResourcesBecauseLastModifiedChangedTest
✅ removeAllPeerReviewsTest
✅ removeServicesTest
✅ removeEmploymentsFailTest
✅ activities_InvitedPositionsFailTest
✅ removeWorksTest
✅ addEmploymentsTest
✅ uploadPeerReviewBecauseLastModifiedChangedTest
✅ removeAllFundingsTest
✅ removeAllServicesTest
✅ recordStatusMarkAllOkTest
✅ removeInvitedPositionsTest
✅ v30RecordDeprecatedExceptionTest
✅ removeAllEmploymentsTest
✅ removeAllMemebershipsTest
✅ uploadNothingTest
✅ activities_ResearchResourcesFailTest
✅ addEducationsTest
✅ removeAllDistinctionsTest
✅ removeAllEducationsTest
✅ addInvitedPositionsTest
✅ removeQualificationsTest
✅ uploadInvitedPositionsBecauseLastModifiedChangedTest
✅ removeServicesFailTest
✅ removeAllWorksTest
✅ uploadEmploymentsBecauseLastModifiedChangedTest
✅ recordSummary_JAXBExceptionTest
✅ activities_ServicesFailTest
✅ removeDistinctionsFailTest
✅ uploadDistinctionBecauseLastModifiedChangedTest
✅ addWorksTest
✅ activities_DistinctionsFailTest
✅ uploadMembershipsBecauseLastModifiedChangedTest
✅ removeFundingsFailTest
✅ uploadWorksBecauseLastModifiedChangedTest
✅ uploadFundingsBecauseLastModifiedChangedTest
✅ uploadEducationsBecauseLastModifiedChangedTest
✅ removeAllInvitedPositionsTest
✅ addResearchResourcesTest
✅ activities_FundingsFailTest
✅ removeAllResearchResourcesTest
✅ activities_WorksFailTest
✅ v30RecordLockedExceptionTest
✅ removeInvitedPositionsFailTest
✅ activities_MembershipsFailTest
✅ removeResearchResourcesTest
✅ removeQualificationsFailTest
✅ activities_EducationsFailTest
✅ removeWorksFailTest
✅ removePeerReviewsTest
✅ activities_PeerReviewsFailTest
✅ removeMembershipsTest
✅ addQualificationsTest

✅ TEST-org.orcid.listener.converter.OrcidRecordToSolrDocumentTest.xml

1 tests were completed in 52ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.listener.converter.OrcidRecordToSolrDocumentTest 1✅ 52ms

✅ org.orcid.listener.converter.OrcidRecordToSolrDocumentTest

✅ convertTest

✅ TEST-org.orcid.listener.persistence.dao.Api20RecordStatusDaoTest.xml

3 tests were completed in 165ms with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.listener.persistence.dao.Api20RecordStatusDaoTest 3✅ 165ms

✅ org.orcid.listener.persistence.dao.Api20RecordStatusDaoTest

✅ updateTest
✅ getTest
✅ createTest

✅ TEST-org.orcid.listener.persistence.dao.Api30RecordStatusDaoTest.xml

3 tests were completed in 52ms with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.listener.persistence.dao.Api30RecordStatusDaoTest 3✅ 52ms

✅ org.orcid.listener.persistence.dao.Api30RecordStatusDaoTest

✅ updateTest
✅ getTest
✅ createTest

✅ TEST-org.orcid.listener.s3.S3MessagingServiceTest.xml

2 tests were completed in 5ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.listener.s3.S3MessagingServiceTest 2✅ 5ms

✅ org.orcid.listener.s3.S3MessagingServiceTest

✅ getV2ActivitiesBucketNameTest
✅ getV3ActivitiesBucketNameTest