Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extids to peer review notification #7046

Merged
merged 25 commits into from
Jul 1, 2024

Update code so it uses string builder

88aa19c
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Add extids to peer review notification #7046

Update code so it uses string builder
88aa19c
Select commit
Loading
Failed to load commit list.
GitHub Actions / orcid-persistence Unit Tests succeeded Jul 1, 2024 in 1s

orcid-persistence Unit Tests ✅

Tests passed successfully

Report Passed Failed Skipped Time
TEST-org.orcid.persistence.dao.AddressDaoTest.xml 5✅ 18s
TEST-org.orcid.persistence.dao.BackupCodesDaoTest.xml 2✅ 2s
TEST-org.orcid.persistence.dao.BiographyDaoTest.xml 4✅ 2s
TEST-org.orcid.persistence.dao.ClientDetailsDaoTest.xml 1✅ 2s
TEST-org.orcid.persistence.dao.ClientSecretDaoTest.xml 3✅ 2s
TEST-org.orcid.persistence.dao.EmailDaoTest.xml 10✅ 2s
TEST-org.orcid.persistence.dao.EmailFrequencyDaoTest.xml 8✅ 2s
TEST-org.orcid.persistence.dao.EventDaoTest.xml 3✅ 2s
TEST-org.orcid.persistence.dao.EventStatsDaoTest.xml 2✅ 482ms
TEST-org.orcid.persistence.dao.ExternalIdentifierDaoTest.xml 7✅ 2s
TEST-org.orcid.persistence.dao.FindMyStuffDaoTest.xml 5✅ 2s
TEST-org.orcid.persistence.dao.IdentifierTypeDaoTest.xml 2✅ 1s
TEST-org.orcid.persistence.dao.InvalidRecordDataChangeDaoTest.xml 22✅ 4s
TEST-org.orcid.persistence.dao.NotificationDao_NoDBPrefillTest.xml 3✅ 2s
TEST-org.orcid.persistence.dao.NotificationDaoTest.xml 12✅ 2s
TEST-org.orcid.persistence.dao.OrcidOauth2AuthoriziationCodeDetailDaoTest.xml 1✅ 2s
TEST-org.orcid.persistence.dao.OrcidOauth2TokenDetailDaoTest.xml 18✅ 2s
TEST-org.orcid.persistence.dao.OrgAffiliationRelationDaoTest.xml 4✅ 2s
TEST-org.orcid.persistence.dao.OrgDisambiguatedDaoTest.xml 4✅ 2s
TEST-org.orcid.persistence.dao.OrgImportLogDaoTest.xml 2✅ 9ms
TEST-org.orcid.persistence.dao.OtherNameDaoTest.xml 7✅ 2s
TEST-org.orcid.persistence.dao.PeerReviewDaoTest.xml 4✅ 2s
TEST-org.orcid.persistence.dao.ProfileDaoTest.xml 17✅ 2s
TEST-org.orcid.persistence.dao.ProfileFundingDaoTest.xml 4✅ 2s
TEST-org.orcid.persistence.dao.ProfileHistoryEventDaoTest.xml 2✅ 2s
TEST-org.orcid.persistence.dao.ProfileKeywordDaoTest.xml 6✅ 2s
TEST-org.orcid.persistence.dao.RecordNameDaoTest.xml 6✅ 2s
TEST-org.orcid.persistence.dao.ResearcherUrlDaoTest.xml 7✅ 2s
TEST-org.orcid.persistence.dao.ResearchResourceDaoTest.xml 6✅ 2s
TEST-org.orcid.persistence.dao.SpamDaoTest.xml 7✅ 2s
TEST-org.orcid.persistence.dao.WebhookDaoTest.xml 5✅ 2s
TEST-org.orcid.persistence.dao.WorkDaoTest.xml 5✅ 2s
TEST-org.orcid.persistence.jpa.entities.FuzzyDateTest.xml 1✅ 1ms
TEST-org.orcid.persistence.jpa.entities.WorkEntityTest.xml 2✅ 0ms

✅ TEST-org.orcid.persistence.dao.AddressDaoTest.xml

5 tests were completed in 18s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.AddressDaoTest 5✅ 18s

✅ org.orcid.persistence.dao.AddressDaoTest

✅ persistTest
✅ findTest
✅ findByOrcidTest
✅ removeAllTest
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.BackupCodesDaoTest.xml

2 tests were completed in 2s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.BackupCodesDaoTest 2✅ 2s

✅ org.orcid.persistence.dao.BackupCodesDaoTest

✅ persistTest
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.BiographyDaoTest.xml

4 tests were completed in 2s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.BiographyDaoTest 4✅ 2s

✅ org.orcid.persistence.dao.BiographyDaoTest

✅ persistTest
✅ testfindByOrcid
✅ mergeTest
✅ testUpdate

✅ TEST-org.orcid.persistence.dao.ClientDetailsDaoTest.xml

1 tests were completed in 2s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.ClientDetailsDaoTest 1✅ 2s

✅ org.orcid.persistence.dao.ClientDetailsDaoTest

✅ testUpdateLastModifiedBulk

✅ TEST-org.orcid.persistence.dao.ClientSecretDaoTest.xml

3 tests were completed in 2s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.ClientSecretDaoTest 3✅ 2s

✅ org.orcid.persistence.dao.ClientSecretDaoTest

✅ testGetNonPrimaryKeys
✅ testLimitedNonPrimaryKeys
✅ testRemoveWithCustomCondition

✅ TEST-org.orcid.persistence.dao.EmailDaoTest.xml

10 tests were completed in 2s with 10 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.EmailDaoTest 10✅ 2s

✅ org.orcid.persistence.dao.EmailDaoTest

✅ testFindOrcidByVerifiedEmail
✅ persistTest
✅ testIsAutoDeprecateEnableForEmail
✅ testRemoveEmail
✅ testVerifyCaseSensitive
✅ testEmailExists
✅ testRemoveEmailCaseSensitive
✅ mergeTest
✅ testVerify
✅ testFindPrimaryEmail

✅ TEST-org.orcid.persistence.dao.EmailFrequencyDaoTest.xml

8 tests were completed in 2s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.EmailFrequencyDaoTest 8✅ 2s

✅ org.orcid.persistence.dao.EmailFrequencyDaoTest

✅ persistTest
✅ updateSendQuarterlyTipsTest
✅ findTest
✅ findByOrcidTest
✅ updateSendChangeNotificationsTest
✅ updateSendAdministrativeChangeNotificationsTest
✅ mergeTest
✅ updateSendMemberUpdateRequestsTest

✅ TEST-org.orcid.persistence.dao.EventDaoTest.xml

3 tests were completed in 2s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.EventDaoTest 3✅ 2s

✅ org.orcid.persistence.dao.EventDaoTest

✅ deletePapiEventsByDate
✅ testWriteEvent
✅ deleteEventsByDate

✅ TEST-org.orcid.persistence.dao.EventStatsDaoTest.xml

2 tests were completed in 482ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.EventStatsDaoTest 2✅ 482ms

✅ org.orcid.persistence.dao.EventStatsDaoTest

✅ createEventStats
✅ createPapiEventStats

✅ TEST-org.orcid.persistence.dao.ExternalIdentifierDaoTest.xml

7 tests were completed in 2s with 7 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.ExternalIdentifierDaoTest 7✅ 2s

✅ org.orcid.persistence.dao.ExternalIdentifierDaoTest

✅ testGetExternalIdentifiers
✅ testGetExternalIdentifiersUsingVisibility
✅ persistTest
✅ testGetExternalIdentifier
✅ testGetExternalIdentifierThatDontBelongToThatUser
✅ removeAllTest
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.FindMyStuffDaoTest.xml

5 tests were completed in 2s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.FindMyStuffDaoTest 5✅ 2s

✅ org.orcid.persistence.dao.FindMyStuffDaoTest

✅ findTest
✅ updateTest
✅ markActioned
✅ markOptOut
✅ createTest

✅ TEST-org.orcid.persistence.dao.IdentifierTypeDaoTest.xml

2 tests were completed in 1s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.IdentifierTypeDaoTest 2✅ 1s

✅ org.orcid.persistence.dao.IdentifierTypeDaoTest

✅ test1AddUpdateFetchID
✅ test4FetchIDList

✅ TEST-org.orcid.persistence.dao.InvalidRecordDataChangeDaoTest.xml

22 tests were completed in 4s with 22 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.InvalidRecordDataChangeDaoTest 22✅ 4s

✅ org.orcid.persistence.dao.InvalidRecordDataChangeDaoTest

✅ invalidValueDescendingTest
✅ havePreviousTest
✅ fetchAllAscendantTest
✅ invalidValueAscendingTest
✅ haveNextTest
✅ fetchAllDescendantTest
✅ fetchPageSize1Test
✅ fetchPageSize2Test
✅ fetchPageSize3Test
✅ fetchPageSize4Test
✅ fetchPageSize5Test
✅ fetchPageSize6Test
✅ fetchPageSize7Test
✅ fetchPageSize8Test
✅ fetchPageSize9Test
✅ fetchPageSize10Test
✅ fetchPageSize11Test
✅ fetchPageSize12Test
✅ fetchPageSize13Test
✅ fetchPageSize14Test
✅ fetchPageSize15Test
✅ fetchPageSize16Test

✅ TEST-org.orcid.persistence.dao.NotificationDao_NoDBPrefillTest.xml

3 tests were completed in 2s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.NotificationDao_NoDBPrefillTest 3✅ 2s

✅ org.orcid.persistence.dao.NotificationDao_NoDBPrefillTest

✅ testTipsNotifications
✅ testServiceAnnouncementNotifications
✅ testFindRecordsWithUnsentNotifications

✅ TEST-org.orcid.persistence.dao.NotificationDaoTest.xml

12 tests were completed in 2s with 12 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.NotificationDaoTest 12✅ 2s

✅ org.orcid.persistence.dao.NotificationDaoTest

✅ archiveOffsetNotificationsTest
✅ testFindCustomNotification
✅ findNotificationsToDeleteByOffsetTest
✅ testFindLatestByOrcid
✅ persistTest
✅ testTipsNotifications
✅ testFindNotificationsToSendLegacy
✅ testFindPermissionByOrcidAndClient
✅ testFindPermissionNotification
✅ testFindNotificationsToSend
✅ testServiceAnnouncementNotifications
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.OrcidOauth2AuthoriziationCodeDetailDaoTest.xml

1 tests were completed in 2s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.OrcidOauth2AuthoriziationCodeDetailDaoTest 1✅ 2s

✅ org.orcid.persistence.dao.OrcidOauth2AuthoriziationCodeDetailDaoTest

✅ isPersistentTokenTest

✅ TEST-org.orcid.persistence.dao.OrcidOauth2TokenDetailDaoTest.xml

18 tests were completed in 2s with 18 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.OrcidOauth2TokenDetailDaoTest 18✅ 2s

✅ org.orcid.persistence.dao.OrcidOauth2TokenDetailDaoTest

✅ disableAccessTokenTest
✅ updateScopesTest
✅ findByUserNameTest
✅ disableClientAccessTokensByUserOrcidTest
✅ findByAuthenticationKeyTest
✅ hasTokenTest
✅ findByRefreshTokenValueTest
✅ disableAccessTokenByIdTest
✅ findNonDisabledByTokenValueTest
✅ findByTokenValueTest
✅ findByClientIdTest
✅ disableAccessTokenByCodeAndClientTest
✅ disableAccessTokenByRefreshTokenTest
✅ tokenRevokedByMemberMustNotOverwriteRevokeReasonIfRevokedByUser
✅ findAvailableScopesByUserAndClientIdTest
✅ revokeAccessTokenTest
✅ findByClientIdAndUserNameTest
✅ disableAccessTokenByUserOrcidTest

✅ TEST-org.orcid.persistence.dao.OrgAffiliationRelationDaoTest.xml

4 tests were completed in 2s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.OrgAffiliationRelationDaoTest 4✅ 2s

✅ org.orcid.persistence.dao.OrgAffiliationRelationDaoTest

✅ persistTest
✅ hasPublicAffiliationsTest
✅ removeAllTest
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.OrgDisambiguatedDaoTest.xml

4 tests were completed in 2s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.OrgDisambiguatedDaoTest 4✅ 2s

✅ org.orcid.persistence.dao.OrgDisambiguatedDaoTest

✅ persistTest
✅ testFindDisambuguatedOrgsWithIncorrectPopularity
✅ testFindBySourceIdAndSourceType
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.OrgImportLogDaoTest.xml

2 tests were completed in 9ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.OrgImportLogDaoTest 2✅ 9ms

✅ org.orcid.persistence.dao.OrgImportLogDaoTest

✅ testGetNextImportSourceName
✅ testGetNextImportSourceNameNoResult

✅ TEST-org.orcid.persistence.dao.OtherNameDaoTest.xml

7 tests were completed in 2s with 7 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.OtherNameDaoTest 7✅ 2s

✅ org.orcid.persistence.dao.OtherNameDaoTest

✅ testGetInvalidOtherName
✅ persistTest
✅ testGetOtherName
✅ testUpdateOtherName
✅ removeAllTest
✅ testfindOtherNameByOrcid
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.PeerReviewDaoTest.xml

4 tests were completed in 2s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.PeerReviewDaoTest 4✅ 2s

✅ org.orcid.persistence.dao.PeerReviewDaoTest

✅ persistTest
✅ removeAllTest
✅ hasPublicPeerReviewsTest
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.ProfileDaoTest.xml

17 tests were completed in 2s with 17 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.ProfileDaoTest 17✅ 2s

✅ org.orcid.persistence.dao.ProfileDaoTest

✅ testAutoDeprecateProfile
✅ testFindUnclaimedNeedingReminder
✅ findEmailsToSendAddWorksFirstAttemptEmail
✅ testUpdateDefaultVisibility
✅ testFindAll
✅ testUpdateIndexingStatus
✅ testFindUnclaimedNotIndexedAfterWaitPeriod
✅ testfindById
✅ testDeprecateProfile
✅ testOrcidsFindByIndexingStatus
✅ testGetClaimedStatusByEmail
✅ testInsertWithPrimaryInstitutions
✅ testOrcidExists
✅ testInsert
✅ testGetConfirmedProfileCount
✅ testInsertWithInstitutionDepartments
✅ testDisable2FA

✅ TEST-org.orcid.persistence.dao.ProfileFundingDaoTest.xml

4 tests were completed in 2s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.ProfileFundingDaoTest 4✅ 2s

✅ org.orcid.persistence.dao.ProfileFundingDaoTest

✅ persistTest
✅ removeAllTest
✅ hasPublicFundingTest
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.ProfileHistoryEventDaoTest.xml

2 tests were completed in 2s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.ProfileHistoryEventDaoTest 2✅ 2s

✅ org.orcid.persistence.dao.ProfileHistoryEventDaoTest

✅ persistTest
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.ProfileKeywordDaoTest.xml

6 tests were completed in 2s with 6 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.ProfileKeywordDaoTest 6✅ 2s

✅ org.orcid.persistence.dao.ProfileKeywordDaoTest

✅ testfindProfileKeywords
✅ testAddProfileKeyword
✅ persistTest
✅ removeAllTest
✅ testDeleteProfileKeyword
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.RecordNameDaoTest.xml

6 tests were completed in 2s with 6 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.RecordNameDaoTest 6✅ 2s

✅ org.orcid.persistence.dao.RecordNameDaoTest

✅ testfindByCreditName
✅ persistTest
✅ testfindByOrcid
✅ testExists
✅ mergeTest
✅ testUpdate

✅ TEST-org.orcid.persistence.dao.ResearcherUrlDaoTest.xml

7 tests were completed in 2s with 7 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.ResearcherUrlDaoTest 7✅ 2s

✅ org.orcid.persistence.dao.ResearcherUrlDaoTest

✅ testDeleteResearcherUrl
✅ persistTest
✅ testAddResearcherUrl
✅ removeAllTest
✅ testfindResearcherUrls
✅ testfindResearcherUrl
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.ResearchResourceDaoTest.xml

6 tests were completed in 2s with 6 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.ResearchResourceDaoTest 6✅ 2s

✅ org.orcid.persistence.dao.ResearchResourceDaoTest

✅ persistTest
✅ testRead
✅ testHasPublicResearchResources
✅ testWriteRI
✅ testWriteRR
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.SpamDaoTest.xml

7 tests were completed in 2s with 7 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.SpamDaoTest 7✅ 2s

✅ org.orcid.persistence.dao.SpamDaoTest

✅ persistTest
✅ testfindByOrcid
✅ testWriteSpam
✅ testUpdateSpamCount
✅ testRemoveSpam
✅ testExists
✅ mergeTest

✅ TEST-org.orcid.persistence.dao.WebhookDaoTest.xml

5 tests were completed in 2s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.WebhookDaoTest 5✅ 2s

✅ org.orcid.persistence.dao.WebhookDaoTest

✅ testFindWebhooksReadyToProcess
✅ testMergeFindAndRemove
✅ testCountWebhooksReadyToProcess
✅ mergeTest
✅ testFindWebhooksReadyToProcessWhenIsNotReadyForRetry

✅ TEST-org.orcid.persistence.dao.WorkDaoTest.xml

5 tests were completed in 2s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.dao.WorkDaoTest 5✅ 2s

✅ org.orcid.persistence.dao.WorkDaoTest

✅ persistTest
✅ getWorksByOrcidIdTest
✅ removeAllWorksTest
✅ mergeTest
✅ testHasPublicWorks

✅ TEST-org.orcid.persistence.jpa.entities.FuzzyDateTest.xml

1 tests were completed in 1ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.jpa.entities.FuzzyDateTest 1✅ 1ms

✅ org.orcid.persistence.jpa.entities.FuzzyDateTest

✅ testFuzzyDateComparison

✅ TEST-org.orcid.persistence.jpa.entities.WorkEntityTest.xml

2 tests were completed in 0ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.persistence.jpa.entities.WorkEntityTest 2✅ 0ms

✅ org.orcid.persistence.jpa.entities.WorkEntityTest

✅ testChronologicallyOrderWorkEntityTest
✅ testWorkEntityComparison