Codereview focus update #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding section with codereview tasks.
rimi-itk
requested changes
Mar 8, 2023
| @@ -76,7 +76,7 @@ For new repositories it was decided to switch back to github, | |||
| composer way to for branch names. | |||
|
|
|||
| <a name="code-review"></a> | |||
| ## Code review | |||
| ## Code review proces | |||
| @@ -93,6 +93,13 @@ NOTE: There are preconditions that have to be met before accepting a pull reques | |||
| - All discussion have to be resolved | |||
| - Pull request should have green Travis CI build status. | |||
|
|
|||
| ##Code review tasks | |||
There was a problem hiding this comment.
Add space after ## like done elsewhere in this file.
| Giving codereview to other developers code should cover | ||
| 1. The use of [Code of conduct](docs#coc) | ||
| 2. The following of the [Testing standards](docs#testing-and-ci) | ||
| 3. That kode is handling successes and errors, can not end in loops and other logical |
There was a problem hiding this comment.
Typo: “kode” should be “code”. Something is missing after “other logical”.
Comment on lines
+98
to
+100
| 1. The use of [Code of conduct](docs#coc) | ||
| 2. The following of the [Testing standards](docs#testing-and-ci) | ||
| 3. That kode is handling successes and errors, can not end in loops and other logical |
There was a problem hiding this comment.
Use consistent spacing after list numbers (cf. https://www.markdownguide.org/basic-syntax/#ordered-lists).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding section with codereview tasks.