Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codereview focus update #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Codereview focus update #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ For new repositories it was decided to switch back to github,
composer way to for branch names.

<a name="code-review"></a>
## Code review
## Code review proces
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: “proces” should be “process”

New changes or bugfixes in existing codebase have to be added to repository
through general [code review process](https://github.com/features/code-review/).
To request a code review, use the following process:
Expand All @@ -93,6 +93,13 @@ NOTE: There are preconditions that have to be met before accepting a pull reques
- All discussion have to be resolved
- Pull request should have green Travis CI build status.

##Code review tasks
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add space after ## like done elsewhere in this file.

Giving codereview to other developers code should cover
1. The use of [Code of conduct](docs#coc)
2. The following of the [Testing standards](docs#testing-and-ci)
3. That kode is handling successes and errors, can not end in loops and other logical
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: “kode” should be “code”. Something is missing after “other logical”.

Comment on lines +98 to +100
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use consistent spacing after list numbers (cf. https://www.markdownguide.org/basic-syntax/#ordered-lists).

4. Other questions the developers might see.

<a name="patching-principles"></a>
## Patching principles
To patch a drupal composer project see:
Expand Down