feat: support base and base sepolia parent chains #1996
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| name: 'Base', | ||
| logo: '/images/BaseWhite.svg', | ||
| description: | ||
| 'Base is built as an Ethereum L2, decentralized with the Optimism Superchain, and incubated by Coinbase.' |
There was a problem hiding this comment.
not sure if we want to update the copy, i grabbed it from their website
| (isSourceChainArbitrum && isDestinationChainOrbit) | ||
| const { isBase: isDestinationChainBase } = isNetwork(destinationChainId) | ||
|
|
||
| const isDeposit = isDepositMode({ sourceChainId, destinationChainId }) | ||
|
|
||
| const isWithdrawal = |
There was a problem hiding this comment.
Wouldn't this work?
const isWithdrawal = !isDepositThere was a problem hiding this comment.
checking with @dewanshparashar
There was a problem hiding this comment.
No we cannot. Because our isSupported flag in bridge-sdk>utils is a union of isDeposit || isWithdrawal || isTeleport and having isWthdrawal = !isDeposit will lead it to support all unsupported combinations.
packages/arb-token-bridge-ui/src/util/__tests__/networks.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bartek <[email protected]>
| // L3 Testnets | ||
| L3Local = 333333 | ||
| } | ||
|
|
||
| type L1Network = { | ||
| type NonArbParentNetwork = { |
There was a problem hiding this comment.
@spsjvc not sure about this name, any suggestions?
spsjvc
changed the title
| ) | ||
| const otherNetworks = chainIds.filter(chainId => isNetwork(chainId).isBase) |
There was a problem hiding this comment.
if we ever add other chains to this group this check would fail, so can we do
| const otherNetworks = chainIds.filter(chainId => isNetwork(chainId).isBase) | |
| const otherNetworks = chainIds.filter(chainId => !isNetwork(chainId).isCoreChain && !isNetwork(chainId).isOrbitChain) |
| ChainId.ArbitrumSepolia | ||
| ChainId.ArbitrumSepolia, | ||
| ChainId.BaseSepolia, | ||
| ChainId.Base |
There was a problem hiding this comment.
Base shouldn't be part of this list, should be only testnets
| if (isL1Chain(chain) && getChildrenForNetwork(chain.chainId).length === 0) { | ||
| // exclude L1 chains or Base Chains with no child chains | ||
| if ( | ||
| !('parentChainId' in chain) && |
| @@ -236,14 +270,19 @@ export const getExplorerUrl = (chainId: ChainId) => { | |||
| export const getL1BlockTime = (chainId: number) => { | |||
| const chain = getChainByChainId(getBaseChainIdByChainId({ chainId })) | |||
|
|
|||
| if (!chain || !isL1Chain(chain)) { | |||
| if (!chain || !('blockTime' in chain)) { | |||
Closes FS-920