-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support base and base sepolia parent chains #1996
Merged
Merged
Changes from 18 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
a9a986d
feat: support base and base sepolia
fionnachan c6eeae8
make tx panel work
fionnachan a08344f
make withdrawal work
fionnachan 1e98126
hide base
fionnachan d8b9b92
hide base
fionnachan dc63d92
fix
fionnachan fd6c48c
Merge branch 'master' into base-and-base-sepolia
fionnachan a7720e9
add networks test for base sepolia and base
fionnachan 778003b
Merge remote-tracking branch 'origin/master' into base-and-base-sepolia
fionnachan 6e4a3af
enable Base but without query param slug
fionnachan 9b25da4
typo
fionnachan 00e73da
support base
fionnachan 2a5fcea
Merge branch 'base-and-base-sepolia' of github.com:OffchainLabs/arbit…
fionnachan 98ed213
update
fionnachan d12e742
Merge remote-tracking branch 'origin/master' into base-and-base-sepolia
fionnachan c48ae9a
update
fionnachan 7b6c89d
update type
fionnachan 2eda65c
update
fionnachan 27dece6
Merge remote-tracking branch 'origin/master' into base-and-base-sepolia
fionnachan 7786875
update desc
fionnachan 199a746
other chains
fionnachan 218d1d2
Merge remote-tracking branch 'origin/master' into base-and-base-sepolia
fionnachan bc449af
update
fionnachan f72375c
revive
fionnachan 9998d33
rename
fionnachan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -104,6 +104,25 @@ export function getBridgeUiConfigForChain(chainId: number): BridgeUiConfig { | |
'AnyTrust protocol. Low fees for high-volume transactions. Secured by a trust-minimized Data Availability Committee (DAC).' | ||
} | ||
} | ||
case ChainId.Base: | ||
return { | ||
color: '#0052ff', | ||
network: { | ||
name: 'Base', | ||
logo: '/images/BaseWhite.svg', | ||
description: | ||
'Base is built as an Ethereum L2, decentralized with the Optimism Superchain, and incubated by Coinbase.' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure if we want to update the copy, i grabbed it from their website There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. waiting for product |
||
} | ||
} | ||
case ChainId.BaseSepolia: | ||
return { | ||
color: '#0052ff', | ||
network: { | ||
name: 'Base Sepolia', | ||
logo: '/images/BaseWhite.svg', | ||
description: 'Base Sepolia is an Ethereum L2 testnet by Coinbase.' | ||
} | ||
} | ||
default: { | ||
// added Orbit chains | ||
const orbitChain = orbitChains[chainId] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checking with @dewanshparashar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we cannot. Because our
isSupported
flag in bridge-sdk>utils is a union ofisDeposit || isWithdrawal || isTeleport
and havingisWthdrawal = !isDeposit
will lead it to support all unsupported combinations.