feat: Dynamically load tokenlists for Orbit chains #2135
Merged
+54
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fionnachan
reviewed
Dec 17, 2024
| originChainID: ChainId.ArbitrumOne, | ||
| url: 'https://tokenlist.arbitrum.io/ArbTokenLists/arbed_arb_whitelist_era.json', | ||
| name: 'Arbitrum Whitelist Era', | ||
| isDefault: true, | ||
| logoURI: ArbitrumLogo | ||
| }, | ||
| { | ||
| id: 2, | ||
| id: '2', |
There was a problem hiding this comment.
we should unify the id syntax and use ${chain.chainId}_native or ${chain.chainId}_uniswap or _cmc etc, then tighten the type
fionnachan
reviewed
Dec 17, 2024
| id: `${chain.chainId}_native`, | ||
| originChainID: chain.chainId, | ||
| url: `https://tokenlist.arbitrum.io/ArbTokenLists/${chain.chainId}_arbed_native_list.json`, | ||
| name: `${chain.name} Arbed L2 native list`, |
There was a problem hiding this comment.
this is actually a bit confusing on the UI
maybe sth like Proof of Play Apex default list?
There was a problem hiding this comment.
a note: if the user has some local storage (visited the bridge before), these new lists seem to be off by default
There was a problem hiding this comment.
- Updated to
${chainName} default list - Already happening in production, fixed in refactor: Remove useArbTokenBridge from store 1/3 #2088 to 2090
dewanshparashar
approved these changes
Dec 17, 2024
fionnachan
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Steps to test