feat: Dynamically load tokenlists for Orbit chains #2135
+54
−70
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,11 +9,13 @@ import CoinGeckoLogo from '@/images/lists/coinGecko.svg' | |
| import ArbitrumLogo from '@/images/lists/ArbitrumLogo.png' | ||
| import { ArbTokenBridge } from '../hooks/arbTokenBridge.types' | ||
| import { ChainId } from './networks' | ||
| import orbitChainsData from './orbitChainsData.json' | ||
|
|
||
| export const SPECIAL_ARBITRUM_TOKEN_TOKEN_LIST_ID = | ||
| 'SPECIAL_ARBITRUM_TOKEN_TOKEN_LIST_ID' | ||
|
|
||
| export interface BridgeTokenList { | ||
| id: string | ||
| originChainID: number | ||
| url: string | ||
| name: string | ||
|
|
@@ -34,39 +36,39 @@ export const BRIDGE_TOKEN_LISTS: BridgeTokenList[] = [ | |
| isArbitrumTokenTokenList: true | ||
| }, | ||
| { | ||
| id: '1', | ||
| originChainID: ChainId.ArbitrumOne, | ||
| url: 'https://tokenlist.arbitrum.io/ArbTokenLists/arbed_arb_whitelist_era.json', | ||
| name: 'Arbitrum Whitelist Era', | ||
| isDefault: true, | ||
| logoURI: ArbitrumLogo | ||
| }, | ||
| { | ||
| id: '2', | ||
| originChainID: ChainId.ArbitrumOne, | ||
| url: 'https://tokenlist.arbitrum.io/ArbTokenLists/arbed_uniswap_labs_default.json', | ||
| name: 'Arbed Uniswap List', | ||
| isDefault: true, | ||
| logoURI: UniswapLogo | ||
| }, | ||
| { | ||
| id: '4', | ||
| originChainID: ChainId.ArbitrumOne, | ||
| url: 'https://tokenlist.arbitrum.io/ArbTokenLists/arbed_coingecko.json', | ||
| name: 'Arbed CoinGecko List', | ||
| isDefault: true, | ||
| logoURI: CoinGeckoLogo | ||
| }, | ||
| { | ||
| id: '5', | ||
| originChainID: ChainId.ArbitrumOne, | ||
| url: 'https://tokenlist.arbitrum.io/ArbTokenLists/arbed_coinmarketcap.json', | ||
| name: 'Arbed CMC List', | ||
| isDefault: false, | ||
| logoURI: CMCLogo | ||
| }, | ||
| { | ||
| id: '6', | ||
| originChainID: ChainId.ArbitrumNova, | ||
| url: 'https://tokenlist.arbitrum.io/ArbTokenLists/42170_arbed_uniswap_labs_default.json', | ||
| name: 'Arbed Uniswap List', | ||
|
|
@@ -78,7 +80,7 @@ export const BRIDGE_TOKEN_LISTS: BridgeTokenList[] = [ | |
| // TODO: remove list for chain ID 412346 after fix: | ||
| // https://github.com/OffchainLabs/arb-token-bridge/issues/564 | ||
| { | ||
| id: '9', | ||
| // Local node | ||
| originChainID: ChainId.ArbitrumLocal, | ||
| url: 'https://tokenlist.arbitrum.io/ArbTokenLists/421613_arbed_coinmarketcap.json', | ||
|
|
@@ -87,7 +89,7 @@ export const BRIDGE_TOKEN_LISTS: BridgeTokenList[] = [ | |
| logoURI: CMCLogo | ||
| }, | ||
| { | ||
| id: '10', | ||
| originChainID: ChainId.ArbitrumSepolia, | ||
| url: 'https://tokenlist.arbitrum.io/ArbTokenLists/421614_arbed_uniswap_labs.json', | ||
| name: 'Arbed Uniswap List', | ||
|
|
@@ -96,76 +98,57 @@ export const BRIDGE_TOKEN_LISTS: BridgeTokenList[] = [ | |
| }, | ||
| // CoinGecko | ||
| { | ||
| id: '11', | ||
| originChainID: ChainId.ArbitrumNova, | ||
| url: 'https://tokenlist.arbitrum.io/ArbTokenLists/42170_arbed_coingecko.json', | ||
| name: 'Arbed CoinGecko List', | ||
| isDefault: true, | ||
| logoURI: CoinGeckoLogo | ||
| }, | ||
| { | ||
| id: '13', | ||
| originChainID: ChainId.ArbitrumSepolia, | ||
| url: 'https://tokenlist.arbitrum.io/ArbTokenLists/421614_arbed_coingecko.json', | ||
| name: 'Arbed CoinGecko List', | ||
| isDefault: true, | ||
| logoURI: CoinGeckoLogo | ||
| }, | ||
| { | ||
| id: '660279', | ||
| // Xai | ||
| originChainID: 660279, | ||
| url: 'tokenLists/660279_default.json', | ||
| name: 'XAI Default List', | ||
| isDefault: true, | ||
| logoURI: '/images/XaiLogo.svg' | ||
| }, | ||
| // For all orbit chains, | ||
| ...orbitChainsData.mainnet | ||
| .concat(orbitChainsData.testnet) | ||
| .reduce((acc, chain) => { | ||
| // Only include arbified native token list for L3 settling to ArbOne | ||
| if (chain.parentChainId === ChainId.ArbitrumOne) { | ||
| acc.push({ | ||
| id: `${chain.chainId}_native`, | ||
| originChainID: chain.chainId, | ||
| url: `https://tokenlist.arbitrum.io/ArbTokenLists/${chain.chainId}_arbed_native_list.json`, | ||
| name: `${chain.name} Arbed L2 native list`, | ||
|
There was a problem hiding this comment. this is actually a bit confusing on the UI maybe sth like 
There was a problem hiding this comment. a note: if the user has some local storage (visited the bridge before), these new lists seem to be off by default There was a problem hiding this comment.
|
||
| isDefault: true, | ||
| logoURI: ArbitrumLogo | ||
| }) | ||
| } | ||
|
|
||
| acc.push({ | ||
| id: `${chain.chainId}_uniswap`, | ||
| originChainID: chain.chainId, | ||
| url: `https://tokenlist.arbitrum.io/ArbTokenLists/${chain.chainId}_arbed_uniswap_labs.json`, | ||
| name: `${chain.name} Arbed Uniswap List`, | ||
fionnachan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| isDefault: true, | ||
| logoURI: UniswapLogo | ||
| }) | ||
|
|
||
| return acc | ||
| }, [] as BridgeTokenList[]) | ||
| ] | ||
|
|
||
| export const listIdsToNames: { [key: string]: string } = {} | ||
|
|
@@ -176,7 +159,7 @@ BRIDGE_TOKEN_LISTS.forEach(bridgeTokenList => { | |
|
|
||
| export interface TokenListWithId extends TokenList { | ||
| l2ChainId: string | ||
| bridgeTokenListId: string | ||
| isValid?: boolean | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should unify the id syntax and use
${chain.chainId}_nativeor${chain.chainId}_uniswapor_cmcetc, then tighten the type