Shiwani Make permission for "Total Valid Weekly Summaries" number editable #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shiwani99
changed the title
|
hi @Shiwani99 . Left the comment at Frontend related PR. Great work! |
malikjahanzaib
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Hi @Shiwani99, tested this PR and it seems to work as intended. Left detailed review on FE PR.
|
Hey! I added my comments on FE #1459. Nice Job! |
|
Hey, I have added a detailed review in PR 1459. Good work. Thank you |
Shuhua-L
approved these changes
Nov 3, 2023
shubhankarval
approved these changes
Nov 4, 2023
|
Hii Shiwani, I have left detailed review at FE Pr#1459 |
- Modified earned date format function in userHelper.js - Added data validation for earned date and badge count mismatch in badgeController.js - Added fillEarnedDateToMatchCount function to resolve earned date and badge count mismatch in badgeController.js - Refactored data validation for duplicate badge id in badgeController.js - Added data validation for badge count should greater than 0 in badgeController.js - Added formatDate function to format date to MMM-DD-YY in badgeController.js
- Update fromatDate in badgeController using moment timezone library - Update earnedDateBadge in userHelper using moment timezone library
…ools_schema Aish_Create buildingTools.js
…nto shengwei_fix_badge_earned_date_issue
…rned_date_issue Shengwei fixed no badge earned date issue
…ctor_of_ownermessage XiaoW_Hotfix and Refactor ownerMessage related backend handler
…Being_Shown_As_Active_On_Map
…_Not_Being_Shown_As_Active_On_Map Fix new active people not being shown as active on map
Vishala Types json file fix
…dhours_not_show_correctly_for_singletask_page XiaoW_Hotfix of logged hours not displaying correctly on single task page
…to the edit lesson controller so users can edit those feilds
space missing
…ff_for_blue_squares
…Json_filepath_fix Vishala Building Units Json file path fix
…x-backend Bailey new personal max backend
…ime_off_for_blue_squares Abdel log requested time off for blue squares
…emake Kaikanes lesson like backend functionality
…epic_validator XiaoW_Hotfix of profile pic validator
…hboardhelper.js src/helpers/taskHelper.js src/startup/routes.js
…ts_Page_sorting Sucheta - Update Projects Page sorting
Pandani07
requested changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related PRS (if any):
To test this backend PR you need to checkout the #1459 frontend PR.
…
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
permission_for_total_valid_weekly_summaries.mov
Note:
Include the information the reviewers need to know.