Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vishala Consumables API #672

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Vishala Consumables API #672

merged 2 commits into from
Jan 7, 2024

Conversation

Vishala09
Copy link
Contributor

@Vishala09 Vishala09 commented Dec 30, 2023 •
edited
Loading

Description

This PR is about the Consumables List View from Phase 2 with Sorting based on project name and item name , Filtering based on selected values of project and consumable and Modal implementation for viewing update and purchase history.
Implements # (WBS) 8.1.2

Related PRS (if any):

To test this backend PR you need to checkout the #1758 frontend PR.

Main changes explained:

  • Created a fetch api for consumables

How to test:

  1. check into current branch
  2. do npm run build and npm run start to run this PR locally
  3. Test api : http://localhost:4500/api/bm/consumables

@Vishala09 Vishala09 mentioned this pull request Dec 30, 2023
Merged
@Vishala09 Vishala09 requested a review from tdkent December 30, 2023 01:51
abdel-lall
abdel-lall approved these changes Dec 30, 2023
View reviewed changes
Copy link
Contributor

@abdel-lall abdel-lall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Screenshot 2023-12-29 233941

Alforoan
Alforoan approved these changes Dec 30, 2023
View reviewed changes
Copy link

@Alforoan Alforoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left my comment on the fe pr #1758

ramyaram2092
ramyaram2092 reviewed Dec 30, 2023
View reviewed changes
Copy link
Contributor

@ramyaram2092 ramyaram2092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a feedback on the front end PR

tdkent
tdkent suggested changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@tdkent tdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only issues are the conflicts on routes.js

ramyaram2092
ramyaram2092 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@ramyaram2092 ramyaram2092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality works as expected. Good Job Vishala !

@tdkent tdkent merged commit 7148218 into development Jan 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alforoan Alforoan Alforoan approved these changes

@tdkent tdkent tdkent approved these changes

@ramyaram2092 ramyaram2092 ramyaram2092 approved these changes

@abdel-lall abdel-lall abdel-lall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vishala09 @abdel-lall @ramyaram2092 @tdkent @Alforoan