Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vishala Consumables Page View #1758

Merged
merged 7 commits into from
Jan 7, 2024
Merged

Vishala Consumables Page View #1758

merged 7 commits into from
Jan 7, 2024

Conversation

Vishala09
Copy link
Contributor

@Vishala09 Vishala09 commented Dec 30, 2023

Description

This PR is about the Consumables List View from Phase 2 with Sorting based on project name and item name , Filtering based on selected values of project and consumable and Modal implementation for viewing update and purchase history.
Implements # (WBS) 8.1.1

Related PRS (if any):

This frontend PR is related to the #672 backend PR.

Main changes explained:

  • Created components for Consumables

How to test:

  1. check into current branch
  2. do npm install and npm run start:local to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. verify all the table functionalities like open/close modals , sorting and filtering

Screenshots or videos of changes:

Untitled_.Dec.29.2023.5_14.PM.webm

@Vishala09 Vishala09 requested a review from tdkent December 30, 2023 01:44
abdel-lall
abdel-lall previously approved these changes Dec 30, 2023
Copy link
Contributor

@abdel-lall abdel-lall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. Good job!

Screenshot 2023-12-29 234022

Alforoan
Alforoan previously approved these changes Dec 30, 2023
Copy link
Contributor

@Alforoan Alforoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All functionalities seem to work as intended. Nice!

pr.review.1758.mp4

Copy link

@ramyaram2092 ramyaram2092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Vishala09 Good job on the functionality. I just notice one issue. First time I load the page the table is empty After I make a selection/interaction in the UI then I see the list of projects in the table. Let me know if this is an acceptable behaviour

I repeated this couple of times to make sure if its a repeated behaviour. After clearing the cache when the page is loaded for the first time this happens

1758.mp4

Copy link
Contributor

@bienzguoa bienzguoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same case as [ramyaram2092] mentioned above, after refreshing, it has projects displayed. Functionality works as intended.
https://github.com/OneCommunityGlobal/HighestGoodNetworkApp/assets/92126559/b2d1cf88-585b-4090-a65e-c93f7d11b09d

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Vishala09,

I saw that you are using px and rem here, would it be better if we consider using the same size unit?

ChengyanOo
ChengyanOo previously approved these changes Jan 5, 2024
Copy link
Member

@ChengyanOo ChengyanOo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Vishala09,

Just went through your code updates – they're super neat and clean, nicely done! Tested out the new feature you implemented as well, and it’s working smoothly. I’ve included a video below for a more detailed walkthrough. Awesome work on the implementation, everything's spot on as you described!

HighestGoodNetworkApp_PR.1758.mp4

@Vishala09 Vishala09 dismissed stale reviews from ChengyanOo, Alforoan, and abdel-lall via 6534c97 January 5, 2024 19:17
@Vishala09
Copy link
Contributor Author

Hello @Vishala09 Good job on the functionality. I just notice one issue. First time I load the page the table is empty After I make a selection/interaction in the UI then I see the list of projects in the table. Let me know if this is an acceptable behaviour
I repeated this couple of times to make sure if its a repeated behaviour. After clearing the cache when the page is loaded for the first time this happens

This issue is resolved. Please do a git pull and re test if necessary.

@Vishala09
Copy link
Contributor Author

Same case as [ramyaram2092] mentioned above, after refreshing, it has projects displayed. Functionality works as intended. https://github.com/OneCommunityGlobal/HighestGoodNetworkApp/assets/92126559/b2d1cf88-585b-4090-a65e-c93f7d11b09d

Thank you for testing. This issue is resolved. Please do a git pull and test if needed.

tdkent
tdkent previously approved these changes Jan 5, 2024
ramyaram2092
ramyaram2092 previously approved these changes Jan 5, 2024
Copy link

@ramyaram2092 ramyaram2092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vishala09 Vishala09 dismissed stale reviews from ramyaram2092 and tdkent via e47436c January 6, 2024 05:09
@tdkent tdkent merged commit 95db05d into development Jan 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants