Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying targets in an inject is not working properly #2112

Open
RomuDeuxfois opened this issue Dec 19, 2024 · 2 comments · May be fixed by #2127
Open

Modifying targets in an inject is not working properly #2112

RomuDeuxfois opened this issue Dec 19, 2024 · 2 comments · May be fixed by #2127
Assignees
Labels
bug use for describing something not working as expected
Milestone

Comments

@RomuDeuxfois
Copy link
Member

RomuDeuxfois commented Dec 19, 2024

Description

Two issues were detected:
A. When I am in the animation tab and I want to modify the teams of my inject, I do not have any teams available although I do have them in the definition tab.
B. When I am in the injects tab and I want to modify the teams of an inject, I can only add them and not delete them via the popup.

Reproducible Steps

Steps to create the smallest reproducible sim:

A.

  1. Go to a current or finished simulation and check that in the definition tab there are teams (if not add some)
  2. Go to the animation tab
  3. Modify an inject to add a team
  4. I have nothing in the list of the popup that appears -> I should have the list of teams that are present in the definition tab

B.

  1. Go to a current or finished simulation and check that in the definition tab there are teams (if not add some)
  2. Go to the inject tab
  3. Modify an inject to remove a team (make sure before this inject already contains teams)
  4. You can delete the team via the small cross on its name to the right of the popup. But when we click on the add button, the team remains present.

Depending on what you want: you should either make it possible to delete a team when you click on the add button and change the name of this button to update.
Either, do not make it possible to have the cross on the name of the team on the list on the right.

@RomuDeuxfois RomuDeuxfois added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Dec 19, 2024
@RomuDeuxfois
Copy link
Member Author

@EllynBsc & @jborozco, any idea for the B issue ?

@EllynBsc EllynBsc removed the needs triage use to identify issue needing triage from Filigran Product team label Dec 20, 2024
@EllynBsc EllynBsc modified the milestone: Bugs backlog Dec 20, 2024
@EllynBsc
Copy link
Member

EllynBsc commented Dec 20, 2024

As discussed this afternoon:

Part A
-Actual output: current teams missing
-Expected output: I should have the list of teams that are present in the definition tab

Part B
We'll go for the following: we change the button 'add' for 'update' so we can keep the ability to add/remove target teams in the inject
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment