Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix accumulation score of expectations #1108

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Jun 18, 2024

Proposed changes

  • Fix naming inconsistencies in properties for store actions.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team labels Jun 18, 2024
@savacano28 savacano28 self-assigned this Jun 18, 2024
@savacano28 savacano28 linked an issue Jun 18, 2024 that may be closed by this pull request
@savacano28 savacano28 force-pushed the bugfix/1021-expectations-cumulating branch from 1b73c2d to c0410db Compare June 18, 2024 16:08
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.84%. Comparing base (fedc5b4) to head (c3a3893).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1108   +/-   ##
=========================================
  Coverage     26.84%   26.84%           
  Complexity     1062     1062           
=========================================
  Files           471      471           
  Lines         11192    11192           
  Branches        567      567           
=========================================
  Hits           3004     3004           
  Misses         8104     8104           
  Partials         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as ready for review June 18, 2024 16:21
@savacano28 savacano28 marked this pull request as draft June 18, 2024 16:22
@SamuelHassine SamuelHassine removed bug use for describing something not working as expected filigran team use to identify PR from the Filigran team labels Jun 18, 2024
@savacano28 savacano28 added filigran team use to identify PR from the Filigran team and removed filigran team use to identify PR from the Filigran team labels Jun 19, 2024
@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Jun 19, 2024
@savacano28 savacano28 force-pushed the bugfix/1021-expectations-cumulating branch from c0410db to c3a3893 Compare June 20, 2024 08:38
@savacano28 savacano28 marked this pull request as ready for review June 20, 2024 08:38
@savacano28 savacano28 requested a review from johanah29 June 20, 2024 08:42
@savacano28 savacano28 added the bug use for describing something not working as expected label Jun 20, 2024
@savacano28 savacano28 merged commit 733e23e into master Jun 20, 2024
7 of 8 checks passed
@savacano28 savacano28 deleted the bugfix/1021-expectations-cumulating branch June 25, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expectations cumulating in front in the validations screen
4 participants