Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow semi-transparent ball-and-sticks and vdw rendering #1783

Merged
merged 6 commits into from
Nov 15, 2024

Ensure VdW settings can be changed for each layer

039e5ac
Select commit
Loading
Failed to load commit list.
Merged

Allow semi-transparent ball-and-sticks and vdw rendering #1783

Ensure VdW settings can be changed for each layer
039e5ac
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Nov 15, 2024 in 4s

2 new alerts

New alerts in code changed by this pull request

  • 1 warning
  • 1 note

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 34 in avogadro/core/layermanager.h

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call from constructor or destructor Warning

Call to virtual function
deserialize
Loading
which is overridden in
LayerBallAndStick
Loading
. If you intend to statically call this virtual function, it should be qualified with LayerData::.
Call to virtual function
deserialize
Loading
which is overridden in
LayerCartoon
Loading
. If you intend to statically call this virtual function, it should be qualified with LayerData::.
Call to virtual function
deserialize
Loading
which is overridden in
LayerLabel
Loading
. If you intend to statically call this virtual function, it should be qualified with LayerData::.
Call to virtual function
deserialize
Loading
which is overridden in
LayerLicorice
Loading
. If you intend to statically call this virtual function, it should be qualified with LayerData::.
Call to virtual function
deserialize
Loading
which is overridden in
LayerVdW
Loading
. If you intend to statically call this virtual function, it should be qualified with LayerData::.
Call to virtual function
deserialize
Loading
which is overridden in LayerWireframe. If you intend to statically call this virtual function, it should be qualified with LayerData::.

Check notice on line 326 in avogadro/qtplugins/ballandstick/ballandstick.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Equality test on floating-point values Note

Equality checks on floating point values can yield unexpected results.

Check notice on line 340 in avogadro/qtplugins/ballandstick/ballandstick.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Equality test on floating-point values Note

Equality checks on floating point values can yield unexpected results.

Check notice on line 354 in avogadro/qtplugins/ballandstick/ballandstick.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Equality test on floating-point values Note

Equality checks on floating point values can yield unexpected results.

Check notice on line 146 in avogadro/qtplugins/vanderwaals/vanderwaals.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Equality test on floating-point values Note

Equality checks on floating point values can yield unexpected results.